From: Hans de Goede <hdegoede@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Fix more __devexit_p glitches
Date: Thu, 04 Jun 2009 18:24:57 +0000 [thread overview]
Message-ID: <4A281179.9000002@redhat.com> (raw)
In-Reply-To: <20090604093041.442ad394@hyperion.delvare>
Hi,
On 06/04/2009 09:30 AM, Jean Delvare wrote:
> Make sure __devexit and devexit_p() match in all hwmon drivers.
> Suggested by a similar fix from Mike Frysinger.
>
> Signed-off-by: Jean Delvare<khali@linux-fr.org>
Looks good to me.
Regards,
Hans
> Cc: Hans de Goede<hdegoede@redhat.com>
> Cc: Jonathan Cameron<jic23@cam.ac.uk>
> ---
> drivers/hwmon/f71882fg.c | 2 +-
> drivers/hwmon/sht15.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.30-rc8.orig/drivers/hwmon/f71882fg.c 2009-06-03 10:55:43.000000000 +0200
> +++ linux-2.6.30-rc8/drivers/hwmon/f71882fg.c 2009-06-04 09:02:47.000000000 +0200
> @@ -253,7 +253,7 @@ static struct platform_driver f71882fg_d
> .name = DRVNAME,
> },
> .probe = f71882fg_probe,
> - .remove = __devexit_p(f71882fg_remove),
> + .remove = f71882fg_remove,
> };
>
> static DEVICE_ATTR(name, S_IRUGO, show_name, NULL);
> --- linux-2.6.30-rc8.orig/drivers/hwmon/sht15.c 2009-04-15 08:40:49.000000000 +0200
> +++ linux-2.6.30-rc8/drivers/hwmon/sht15.c 2009-06-04 09:25:30.000000000 +0200
> @@ -627,35 +627,35 @@ static struct platform_driver sht_driver
> .owner = THIS_MODULE,
> },
> .probe = sht15_probe,
> - .remove = sht15_remove,
> + .remove = __devexit_p(sht15_remove),
> }, {
> .driver = {
> .name = "sht11",
> .owner = THIS_MODULE,
> },
> .probe = sht15_probe,
> - .remove = sht15_remove,
> + .remove = __devexit_p(sht15_remove),
> }, {
> .driver = {
> .name = "sht15",
> .owner = THIS_MODULE,
> },
> .probe = sht15_probe,
> - .remove = sht15_remove,
> + .remove = __devexit_p(sht15_remove),
> }, {
> .driver = {
> .name = "sht71",
> .owner = THIS_MODULE,
> },
> .probe = sht15_probe,
> - .remove = sht15_remove,
> + .remove = __devexit_p(sht15_remove),
> }, {
> .driver = {
> .name = "sht75",
> .owner = THIS_MODULE,
> },
> .probe = sht15_probe,
> - .remove = sht15_remove,
> + .remove = __devexit_p(sht15_remove),
> },
> };
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2009-06-04 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 7:30 [lm-sensors] [PATCH] hwmon: Fix more __devexit_p glitches Jean Delvare
2009-06-04 18:24 ` Hans de Goede [this message]
2009-06-10 16:11 ` Jim Cromie
2009-06-10 16:24 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A281179.9000002@redhat.com \
--to=hdegoede@redhat.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.