From: Yinghai Lu <yinghai@kernel.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Avi Kivity <avi@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpumask: alloc blank cpumask left over
Date: Thu, 04 Jun 2009 22:56:57 -0700 [thread overview]
Message-ID: <4A28B3A9.3010505@kernel.org> (raw)
In-Reply-To: <200906051428.08299.rusty@rustcorp.com.au>
Rusty Russell wrote:
> On Fri, 5 Jun 2009 06:31:31 am Yinghai Lu wrote:
>> avoid suprise when MAXSMP is enabled
>>
>> Signed-off-by: Yinghai Lu <yinghai.lu@kernel.org>
>
> I understand the temptation, but two questions arise:
> 1) Shouldn't we actually audit to see if any of these are currently problems,
those are defined as static cpumask_var_t, and if MAXSMP is not used, they are cleared already
> and
> 2) Should the non-MAXSMP alloc_cpumask_var_node (currently a noop) zero the
> mask if __GFP_ZERO is set?
No. in that case, should cpumask_clear instead.
YH
next prev parent reply other threads:[~2009-06-05 5:57 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:00 [PATCH] kvm: fix kvm reboot crash when MAXSMP is used Yinghai Lu
2009-06-04 21:01 ` [PATCH] cpumask: alloc blank cpumask left over Yinghai Lu
2009-06-05 4:58 ` Rusty Russell
2009-06-05 5:18 ` Avi Kivity
2009-06-05 5:56 ` Yinghai Lu [this message]
2009-06-05 13:41 ` Rusty Russell
2009-06-05 17:34 ` Linus Torvalds
2009-06-05 17:46 ` Yinghai Lu
2009-06-05 17:57 ` Yinghai Lu
2009-06-06 23:40 ` Rusty Russell
2009-06-06 23:43 ` Rusty Russell
2009-06-06 9:22 ` Avi Kivity
2009-06-06 9:36 ` Yinghai Lu
2009-06-06 9:39 ` Avi Kivity
2009-06-06 10:57 ` Yinghai Lu
2009-06-06 21:50 ` [PATCH 1/6] cpumask: introduce zalloc_cpumask_var Yinghai Lu
2009-06-06 21:51 ` Subject: [PATCH 2/6] cpumask: alloc zeroed cpumask for static cpumask_var_ts Yinghai Lu
2009-06-06 21:52 ` [PATCH 3/6] kvm: fix kvm reboot crash when MAXSMP is used Yinghai Lu
2009-06-06 21:53 ` [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of = Yinghai Lu
2009-06-09 6:57 ` Rusty Russell
2009-06-09 8:13 ` Yinghai Lu
2009-06-10 4:20 ` Rusty Russell
2009-06-10 13:39 ` Dave Jones
2009-06-10 17:01 ` Ingo Molnar
2009-06-09 15:46 ` Linus Torvalds
2009-06-09 16:28 ` Dave Jones
2009-06-09 16:41 ` Linus Torvalds
2009-06-10 4:55 ` Rusty Russell
2009-06-10 6:22 ` Rusty Russell
2009-06-10 11:10 ` S06cpuspeed/2637 is trying to acquire lock (&(&dbs_info->work)->work (was: Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =) Ingo Molnar
2009-06-10 20:58 ` Dave Jones
2009-06-11 10:52 ` Ingo Molnar
2009-06-20 12:48 ` Ingo Molnar
2009-06-21 19:55 ` Thomas Renninger
2009-06-23 18:17 ` [PATCH] cpufreq: remove dbs_mutex Ingo Molnar
2009-06-23 18:40 ` Ingo Molnar
2009-06-23 18:51 ` Pallipadi, Venkatesh
2009-06-23 19:14 ` Ingo Molnar
2009-06-23 19:24 ` Pallipadi, Venkatesh
2009-06-23 19:32 ` Ingo Molnar
[not found] ` <20090623193215.GA31374-X9Un+BFzKDI@public.gmane.org>
2009-06-25 14:01 ` Fix dead lock in cpufreq for CPU hotplug and suspend for 2.6.30.stable Thomas Renninger
2009-06-25 14:01 ` Thomas Renninger
[not found] ` <1245938485-12663-1-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2009-06-25 14:06 ` Thomas Renninger
2009-06-25 14:06 ` Thomas Renninger
2009-06-25 14:01 ` [PATCH 1/2] CPUFREQ: Remove unneeded dbs_mutexes from ondemand and conservative governors Thomas Renninger
[not found] ` <1245938485-12663-2-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2009-06-25 14:25 ` Mathieu Desnoyers
2009-06-25 14:25 ` Mathieu Desnoyers
2009-06-25 15:03 ` Pallipadi, Venkatesh
2009-06-25 15:03 ` Pallipadi, Venkatesh
2009-06-25 22:17 ` Thomas Renninger
2009-06-25 22:17 ` Thomas Renninger
[not found] ` <200906260017.10730.trenn-l3A5Bk7waGM@public.gmane.org>
2009-06-25 22:26 ` Thomas Renninger
2009-06-25 22:26 ` Thomas Renninger
2009-06-30 6:33 ` Pavel Machek
2009-06-30 6:33 ` Pavel Machek
[not found] ` <20090630063339.GF1351-+ZI9xUNit7I@public.gmane.org>
2009-07-03 10:10 ` Thomas Renninger
2009-07-03 10:10 ` Thomas Renninger
2009-07-05 19:46 ` Pavel Machek
2009-06-30 22:58 ` [stable] " Greg KH
2009-06-30 22:58 ` Greg KH
[not found] ` <20090630225813.GB2634-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-06-30 23:14 ` Mathieu Desnoyers
2009-06-30 23:14 ` Mathieu Desnoyers
2009-06-30 23:39 ` Greg KH
2009-06-30 23:39 ` Greg KH
[not found] ` <20090630233912.GA3709-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2009-07-01 9:07 ` Thomas Renninger
2009-07-01 9:07 ` Thomas Renninger
2009-06-25 14:01 ` [PATCH 2/2] remove rwsem lock from CPUFREQ_GOV_STOP call (second call site) Thomas Renninger
2009-06-10 19:42 ` [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of = Langsdorf, Mark
2009-06-11 2:34 ` Rusty Russell
2009-09-21 16:44 ` Langsdorf, Mark
2009-06-06 21:55 ` [PATCH 5/6] core: use cpumask_copy instead of = for cpus_allowed in fork Yinghai Lu
2009-06-06 21:56 ` [PATCH 6/6] x86/cpufreq: don't use SPEEDSTEP with MAXSMP Yinghai Lu
2009-06-06 21:56 ` [PATCH 1/6] cpumask: introduce zalloc_cpumask_var Andrew Morton
2009-06-06 22:07 ` Yinghai Lu
2009-06-06 21:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A28B3A9.3010505@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.