From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] netfilter: MASQUERADE: remove redundant rwlock
Date: Fri, 05 Jun 2009 13:27:50 +0200 [thread overview]
Message-ID: <4A290136.4040204@trash.net> (raw)
In-Reply-To: <1244164542-10739-4-git-send-email-fw@strlen.de>
Florian Westphal wrote:
> The lock "protects" an assignment and a comparision of an integer.
> When the caller of device_cmp() evaluates the result, nat->masq_index
> may already have been changed (regardless if the lock is there or not).
>
> So, the lock either has to be held during nf_ct_iterate_cleanup(),
> or can be removed.
>
> This does the latter.
Agreed, its useless. Applied, thanks.
prev parent reply other threads:[~2009-06-05 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 1:15 NFQUEUE balancing extension (kernel changes) Florian Westphal
2009-06-05 1:15 ` [PATCH 1/3] netfilter: NFQUEUE use NFPROTO_UNSPEC Florian Westphal
2009-06-05 11:19 ` Patrick McHardy
2009-06-05 1:15 ` [PATCH 2/3] netfilter: NFQUEUE: queue balancing support Florian Westphal
2009-06-05 9:50 ` Pablo Neira Ayuso
2009-06-05 10:43 ` Holger Eitzenberger
2009-06-05 11:26 ` Patrick McHardy
2009-06-05 13:35 ` Florian Westphal
2009-06-05 13:07 ` Jan Engelhardt
2009-06-05 13:23 ` Jan Engelhardt
2009-06-05 1:15 ` [PATCH 3/3] netfilter: MASQUERADE: remove redundant rwlock Florian Westphal
2009-06-05 11:27 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A290136.4040204@trash.net \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.