From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Adding a composite device, how to structure ?
Date: Sat, 06 Jun 2009 08:23:57 +0200 [thread overview]
Message-ID: <4A2A0B7D.7060609@denx.de> (raw)
In-Reply-To: <4A296B3C.1060208@windriver.com>
Hello Tom,
Tom wrote:
> I would like to add support for the twl4030, a composite i2c device,
> found on the omap3 zoom's.
> The header file will be include/twl4030.h.
> How do you want the source to be structured ?
> 1. A single large file in drivers/i2c/twl4030.c
>
> or device files added under a directory ?
>
> 2. drivers/i2c/twl4030/keyboard, drivers/i2c/twl4030/usb,
> drivers/i2c/twl4030/battery,
>
> or just the common code in i2c and twl4030 devices in the places they
> usually go.
>
> 3. drivers/i2c/twl4030.c, drivers/usb/tw4030_usb.c etc ..
>
> My guess is #3.
Yep, I think #3 is the right way to go.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2009-06-06 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 19:00 [U-Boot] Adding a composite device, how to structure ? Tom
2009-06-05 20:40 ` Wolfgang Denk
2009-06-06 6:23 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2A0B7D.7060609@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.