All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: James Pike <james@chilon.net>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] fix detection of kernel source directory
Date: Mon, 08 Jun 2009 10:31:37 +0200	[thread overview]
Message-ID: <4A2CCC69.2030709@siemens.com> (raw)
In-Reply-To: <20090603125954.GA16220@dupont.ts-a>

James Pike wrote:
> Fix detection of kernel source directory when it is different to build
> directory.
> Signed-off-by: James Pike <james@chilon.net>
> 
> diff --git a/configure b/configure
> index e01ba98..c3b7a5f 100755
> --- a/configure
> +++ b/configure
> @@ -91,7 +91,7 @@ arch=${arch%%-*}
>  
>  # see if we have split build and source directories
>  if [ -d "$kerneldir/include2" ]; then
> -    kernelsourcedir=${kerneldir%/*}/source
> +    kernelsourcedir=`readlink -f $kerneldir/source`
>  fi
>  
>  if [ -n "$no_uname" -a "$want_module" ]; then

So far I can't reproduce any problem that the above could fix, but maybe
Avi sees why we need it and that it doesn't regress elsewhere.

Jan

  reply	other threads:[~2009-06-08  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 12:59 [PATCH] fix detection of kernel source directory James Pike
2009-06-08  8:31 ` Jan Kiszka [this message]
2009-06-08  8:49   ` Avi Kivity
2009-08-15 22:24     ` James Pike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2CCC69.2030709@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=james@chilon.net \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.