From: Avi Kivity <avi@redhat.com>
To: James Pike <james@chilon.net>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] fix include paths when the kernel source and build directory are different
Date: Mon, 08 Jun 2009 11:42:05 +0300 [thread overview]
Message-ID: <4A2CCEDD.6000006@redhat.com> (raw)
In-Reply-To: <20090603125840.GA16209@dupont.ts-a>
James Pike wrote:
> Use correct architecture includes when kernel source and build directory
> are different.
> Signed-off-by: James Pike <james@chilon.net>
>
> --- a/Makefile
> +++ b/Makefile
> @@ -27,8 +27,9 @@ all:: prerequisite
> # include header priority 1) $LINUX 2) $KERNELDIR 3) include-compat
> $(MAKE) -C $(KERNELDIR) M=`pwd` \
> LINUXINCLUDE="-I`pwd`/include -Iinclude \
> - $(if $(KERNELSOURCEDIR),-Iinclude2 -I$(KERNELSOURCEDIR)/include) \
> - -Iarch/${ARCH_DIR}/include -I`pwd`/include-compat \
> + $(if $(KERNELSOURCEDIR),\
> + -Iinclude2 -I$(KERNELSOURCEDIR)/include -I$(KERNELSOURCEDIR)/arch/${ARCH_DIR}/include, \
> + -Iarch/${ARCH_DIR}/include) -I`pwd`/include-compat \
> -include include/linux/autoconf.h \
> -include `pwd`/$(ARCH_DIR)/external-module-compat.h $(module_defines)" \
> "$$@"
>
This removes -Iarch/${ARCH_DIR}/include when KERNELSOURCEDIR is not
defined. What is the reason for this change?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-08 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 12:58 [PATCH] fix include paths when the kernel source and build directory are different James Pike
2009-06-08 8:31 ` Jan Kiszka
2009-06-08 8:42 ` Avi Kivity [this message]
2009-06-08 9:04 ` Jan Kiszka
2009-06-08 9:33 ` Avi Kivity
2009-08-15 22:33 ` James Pike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2CCEDD.6000006@redhat.com \
--to=avi@redhat.com \
--cc=james@chilon.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.