From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] decouple vcpu index from apic id Date: Mon, 08 Jun 2009 14:25:10 +0300 Message-ID: <4A2CF516.7080206@redhat.com> References: <1244453578-29857-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Carsten Otte , Hollis Blanchard , "Zhang, Xiantao" To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45047 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbZFHLZM (ORCPT ); Mon, 8 Jun 2009 07:25:12 -0400 In-Reply-To: <1244453578-29857-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > Currently vcpu_id is used as an index into vcpus array and as apic id > on x86. This is incorrect since apic ids not have to be continuous > (they can also encode cpu hierarchy information) and may have values > bigger then vcpu array in case of x2apic. This series removes use of > vcpu_id as vcpus array index. Each architecture may use it how it sees > fit. x86 uses it as apic id. > > Apart from my minor comments, this looks good, but I'd like to get acks from arch maintainers to avoid surprises. Xiantao, does setting the bsp id make sense for ia64? -- error compiling committee.c: too many arguments to function