From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA Date: Tue, 09 Jun 2009 06:37:16 +0300 Message-ID: <4A2DD8EC.1070503@redhat.com> References: <1244497683-14391-1-git-send-email-aliguori@us.ibm.com> <1244497683-14391-2-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, "qemu-devel@nongnu.org" , Anthony Liguori To: Nolan Return-path: Received: from mx2.redhat.com ([66.187.237.31]:40743 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144AbZFIDhJ (ORCPT ); Mon, 8 Jun 2009 23:37:09 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: (redirecting) Nolan wrote: > Anthony Liguori us.ibm.com> writes: > >> >> This is needed for VMware VGA to work properly under KVM. >> >> Signed-off-by: Anthony Liguori us.ibm.com> >> --- >> hw/vmware_vga.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c >> index bb17698..246011b 100644 >> --- a/hw/vmware_vga.c >> +++ b/hw/vmware_vga.c >> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int >> > region_num, > >> #endif >> cpu_register_physical_memory(s->vram_base, s->vga.vram_size, >> iomemtype); >> + >> + s->vga.map_addr = addr; >> + s->vga.map_end = addr + s->vga.vram_size; >> + vga_dirty_log_start(&s->vga); >> } >> >> void pci_vmsvga_init(PCIBus *bus) >> > > Using the MMU to track writes to VRAM should only be needed when the FIFO is > disabled. When the FIFO is enabled (SVGA_REG_CONFIG_DONE = 1), the guest will > notify the host via the FIFO when it has written to a region of VRAM directly, > using the SVGA_CMD_UPDATE FIFO command. > > Unless I'm confused, this change appears to use the MMU to track VRAM updates > unconditionally. > -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.