From: Stephen Boyd <bebarino@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH] show-branch: fix segfault when showbranch.default exists
Date: Tue, 09 Jun 2009 00:17:28 -0700 [thread overview]
Message-ID: <4A2E0C88.70805@gmail.com> (raw)
In-Reply-To: <7vfxe9udln.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> I am not sure if this is a bug in parse_options(), or a bug in the caller,
> and tonight I do not have enough concentration to figure out which. In
> any case, this patch works the issue around.
I am low on concentration tonight as well, but this looks right to me.
Parse options is expecting the regular old argv and argc. I overlooked
this code path during the conversion (though I remember figuring out
what this path was doing). Faking the argv and argc a little more
accurately, like you do, should work fine.
On a side note, I can't remember why I used
PARSE_OPT_STOP_AT_NON_OPTION. I think it should be 0.
next prev parent reply other threads:[~2009-06-09 7:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 6:26 [PATCH] show-branch: fix segfault when showbranch.default exists Junio C Hamano
2009-06-09 7:17 ` Stephen Boyd [this message]
2009-06-09 8:06 ` Pierre Habouzit
2009-06-09 16:28 ` Junio C Hamano
2009-06-09 17:23 ` Pierre Habouzit
2009-06-09 17:35 ` branch management Harry Duin
2009-06-09 19:50 ` Alex Riesen
2009-06-10 14:02 ` Harry Duin
2009-06-10 14:43 ` Jakub Narebski
2009-06-10 15:28 ` Nicolas Pitre
2009-06-10 17:37 ` Linus Torvalds
2009-06-10 19:14 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2E0C88.70805@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.