From: Eric Dumazet <eric.dumazet@gmail.com>
To: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Cc: David Miller <davem@davemloft.net>,
j.dumon@option.com, netdev@vger.kernel.org
Subject: Re: [PATCH] hso: add missing last_rx setting
Date: Tue, 09 Jun 2009 16:37:26 +0200 [thread overview]
Message-ID: <4A2E73A6.5070708@gmail.com> (raw)
In-Reply-To: <4A2E6C31.2070402@teltonika.lt>
Paulius Zaleckas a écrit :
> David Miller wrote:
>> From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
>> Date: Thu, 04 Jun 2009 18:50:23 +0300
>>
>>> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
>> The core networking does this now for the drivers, they
>> don't need to do it themselves any longer.
>
> Where? I couldn't find it even in net-next...
vi +1937 include/linux/netdevice.h
/* On bonding slaves other than the currently active slave, suppress
* duplicates except for 802.3ad ETH_P_SLOW, alb non-mcast/bcast, and
* ARP on active-backup slaves with arp_validate enabled.
*/
static inline int skb_bond_should_drop(struct sk_buff *skb)
{
struct net_device *dev = skb->dev;
struct net_device *master = dev->master;
if (master) {
if (master->priv_flags & IFF_MASTER_ARPMON)
dev->last_rx = jiffies;
...
commit 6cf3f41e6c08bca6641a695449791c38a25f35ff
Author: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon Nov 3 18:16:50 2008 -0800
bonding, net: Move last_rx update into bonding recv logic
The only user of the net_device->last_rx field is bonding.
This patch adds a conditional update of last_rx to the bonding special
logic in skb_bond_should_drop, causing last_rx to only be updated when
the ARP monitor is running.
This frees network device drivers from the necessity of
updating last_rx, which can have cache line thrash issues.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
prev parent reply other threads:[~2009-06-09 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 15:50 [PATCH] hso: add missing last_rx setting Paulius Zaleckas
2009-06-04 22:42 ` David Miller
2009-06-09 14:05 ` Paulius Zaleckas
2009-06-09 14:37 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2E73A6.5070708@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=j.dumon@option.com \
--cc=netdev@vger.kernel.org \
--cc=paulius.zaleckas@teltonika.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.