From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic
Date: Tue, 09 Jun 2009 17:51:20 +0200 [thread overview]
Message-ID: <4A2E84F8.7020303@redhat.com> (raw)
In-Reply-To: <200906091632.19195.paul@codesourcery.com>
On 06/09/09 17:32, Paul Brook wrote:
> On Tuesday 09 June 2009, Gerd Hoffmann wrote:
>> On 06/09/09 17:01, Paul Brook wrote:
>>>> + qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
>>> This should be using sysbus_init_irq.
>>>
>>> Paul
>> Patch 3/3 kills that line anyway ...
>
> It's still wrong.
Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?
What is the point in maintaining qemu_irqs in SysBusDevice directly and
ignoring the qemu_irqs in DeviceState (aka SysBusDevice.qdev)?
cheers,
Gerd
next prev parent reply other threads:[~2009-06-09 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 11:00 [Qemu-devel] [PATCH 1/3] qdev-ify isa pic Gerd Hoffmann
2009-06-09 11:01 ` [Qemu-devel] [PATCH 2/3] qdev: irq allocation in generic code Gerd Hoffmann
2009-06-09 11:01 ` [Qemu-devel] [PATCH 3/3] qdev: switch isa pic to generic irq allocation Gerd Hoffmann
2009-06-09 15:01 ` [Qemu-devel] [PATCH 1/3] qdev-ify isa pic Paul Brook
2009-06-09 15:24 ` Gerd Hoffmann
2009-06-09 15:32 ` Paul Brook
2009-06-09 15:51 ` Gerd Hoffmann [this message]
2009-06-09 15:58 ` Paul Brook
2009-06-10 7:32 ` Gerd Hoffmann
2009-06-10 9:43 ` Filip Navara
2009-06-10 9:50 ` Gerd Hoffmann
2009-06-10 14:29 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2E84F8.7020303@redhat.com \
--to=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.