All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] virtio-serial: PCI device for simple host <-> guest communication
Date: Tue, 09 Jun 2009 21:19:46 +0200	[thread overview]
Message-ID: <4A2EB5D2.8030107@web.de> (raw)
In-Reply-To: <20090609181522.GA11485@amd.home.annexia.org>

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

Richard W.M. Jones wrote:
> On Tue, Jun 09, 2009 at 07:15:25PM +0200, Jan Kiszka wrote:
>> Amit Shah wrote:
>>> This interface presents a char device from which bits can be
>>> sent and read.
>>>
>>> Sample uses for such a device can be obtaining info from the
>>> guest like the file systems used, apps installed, etc. for
>>> offline usage and logged-in users, clipboard copy-paste, etc.
>>> for online usage.
>> Out of curiosity: What is the advantage over instantiating a multiport
>> 16550A PCI card? Will those channels be so performance critical?
> 
> 16550A has a couple of problems: The fixed sized FIFO (16 bytes) can
> cause problems if you send data too quickly.  (I've seen this problem
> when sending too much data from host to the guest, but I can't find
> the bug report right now ...).

If you buy a real 16550A card with high-speed support (eg. 1 MBit/s),
you get larger FIFOs (eg. 256 byte). Thresholds are scaled
correspondingly by such cards. So there would be no problem in extending
this in QEMU as well, ie. making it a parameter to the init function.

>  Secondly UARTs are complicated to
> emulate compared to a clean virtio device.  Would we be happy with the
> address space taken up and amount of emulation going on once we had,
> say, 16 emulated ports?

Memory-mapped 16550As do not suffer from such a limitation.

> 
> On the other hand, multiport cards don't require special drivers in
> the guest ...

That's what raised my interest: What benefit of a virtio-serial can
over-compensate this advantage of standard hardware?

Jan



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2009-06-09 19:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 16:42 [Qemu-devel] [RFC] virtio-serial device Amit Shah
2009-06-09 16:42 ` [Qemu-devel] [PATCH] pci: add define for communication class devices Amit Shah
2009-06-09 16:42   ` [Qemu-devel] [PATCH] qdev: add virtserial char drv init hacks Amit Shah
2009-06-09 16:42     ` [Qemu-devel] [PATCH] virtio-serial: PCI device for simple host <-> guest communication Amit Shah
2009-06-09 17:15       ` [Qemu-devel] " Jan Kiszka
2009-06-09 18:15         ` Richard W.M. Jones
2009-06-09 19:19           ` Jan Kiszka [this message]
2009-06-09 18:17       ` [Qemu-devel] " Richard W.M. Jones
2009-06-09 18:47         ` Stuart Brady
2009-06-09 18:56         ` Anthony Liguori
2009-06-09 23:40           ` Paul Brook
2009-06-10 10:31           ` Amit Shah
2009-06-10 18:00             ` Jamie Lokier
2009-06-11  4:31               ` Amit Shah
2009-06-12  1:56                 ` Jamie Lokier
2009-06-11 13:51           ` Amit Shah
2009-06-11 16:07             ` Blue Swirl
2009-06-11 16:21               ` Amit Shah
2009-06-10 10:28         ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2EB5D2.8030107@web.de \
    --to=jan.kiszka@web.de \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.