From: Antti Palosaari <crope@iki.fi>
To: Jan Nikitenko <jan.nikitenko@gmail.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH] af9015: fix stack corruption bug
Date: Wed, 10 Jun 2009 03:06:58 +0300 [thread overview]
Message-ID: <4A2EF922.5040102@iki.fi> (raw)
In-Reply-To: <c4bc83220906091531h20677733kd993ed50c0bc74ec@mail.gmail.com>
On 06/10/2009 01:31 AM, Jan Nikitenko wrote:
> This patch fixes stack corruption bug present in af9015_eeprom_dump():
> the buffer buf is one byte smaller than required - there is 4 chars
> for address prefix, 16*3 chars for dump of 16 eeprom bytes per line
> and 1 byte for zero ending the string required, i.e. 53 bytes, but
> only 52 are provided.
> The one byte missing in stack based buffer buf causes following oops
> on MIPS little endian platform, because i2c_adap pointer in
> af9015_af9013_frontend_attach() is corrupted by inlined function
> af9015_eeprom_dump():
> Signed-off-by: Jan Nikitenko<jan.nikitenko@gmail.com>
Acked-by: Antti Palosaari <crope@iki.fi>
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2009-06-10 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 22:31 [PATCH] af9015: fix stack corruption bug Jan Nikitenko
2009-06-10 0:06 ` Antti Palosaari [this message]
2009-06-18 11:12 ` [PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump Jan Nikitenko
2009-06-18 11:22 ` Jan Nikitenko
2009-06-18 21:00 ` Trent Piepho
2009-06-19 7:32 ` [PATCH v2] af9015: avoid magically sized temporary " Jan Nikitenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2EF922.5040102@iki.fi \
--to=crope@iki.fi \
--cc=jan.nikitenko@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.