All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grzegorz Bernacki <gjb@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] digsy MTC: Add SPI support.
Date: Wed, 10 Jun 2009 16:03:42 +0200	[thread overview]
Message-ID: <4A2FBD3E.9000602@semihalf.com> (raw)
In-Reply-To: <m2k53k2u8n.fsf@ohwell.denx.de>


> 
>> +#ifdef CONFIG_MPC52XX_SPI
>> +	/* SPI on Tmr2/3/4/5 pins */
>> +	setbits_be32(&gpio->port_config, (1 << 29));
> 
> Sorry for missing this on the first round, but as this is always defined
> we should work this into CONFIG_SYS_GPS_PORT_CONFIG in digsy_mtc.h.  A
> comment explaining this (as far as easily possible) would also be nice.
> include/configs/inka4x0.h is a nice example on how to do this.
> 

Setting this bit is unnecessary since it is already set in
CONFIG_SYS_GPS_PORT_CONFIG which is used in digsy. I will create
another patch in which I add some comment to this define.

Grzesiek

  reply	other threads:[~2009-06-10 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 12:14 [U-Boot] [PATCH v2 1/3] mpc52xx: Add SPI driver Grzegorz Bernacki
2009-06-09 12:14 ` [U-Boot] [PATCH v2 2/3] digsy MTC: Add SPI support Grzegorz Bernacki
2009-06-10 11:39   ` Detlev Zundel
2009-06-10 14:03     ` Grzegorz Bernacki [this message]
2009-06-09 12:14 ` [U-Boot] [PATCH v2 3/3] digsy MTC: Add 'mtc' command Grzegorz Bernacki
2009-06-10 11:33 ` [U-Boot] [PATCH v2 1/3] mpc52xx: Add SPI driver Detlev Zundel
2009-06-10 12:50   ` Grzegorz Bernacki
2009-06-10 13:29     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2FBD3E.9000602@semihalf.com \
    --to=gjb@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.