From: Jeff Garzik <jeff@garzik.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-ide@vger.kernel.org, htejun@gmail.com
Subject: Re: [PATCH 1/2] libata: switch to using block layer tagging support
Date: Wed, 10 Jun 2009 11:11:41 -0400 [thread overview]
Message-ID: <4A2FCD2D.3040205@garzik.org> (raw)
In-Reply-To: <20090520070038.GE11363@kernel.dk>
Jens Axboe wrote:
> libata currently has a pretty dumb ATA_MAX_QUEUE loop for finding
> a free tag to use. Instead of fixing that up, convert libata to
> using block layer tagging - gets rid of code in libata, and is also
> much faster.
>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> ---
> drivers/ata/libata-core.c | 65 ++++----------------------------------------
> drivers/ata/libata-scsi.c | 23 ++++++++++++++-
> drivers/ata/libata.h | 19 ++++++++++++-
> include/linux/libata.h | 1 -
> 4 files changed, 44 insertions(+), 64 deletions(-)
Patch looks good to me, with regards (a) simplex, (b) master/slave, (c)
non-queued and (d) NCQ. I'm not confident about the PMP case, but if
Tejun is happy, I guess I can go ahead and queue these...
Jeff
next prev parent reply other threads:[~2009-06-10 15:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 6:59 [PATCH 0/2] libata: switch to block layer tagging Jens Axboe
2009-05-20 7:00 ` [PATCH 1/2] libata: switch to using block layer tagging support Jens Axboe
2009-05-20 11:53 ` Tejun Heo
2009-05-20 17:10 ` Grant Grundler
2009-05-20 18:08 ` Gwendal Grignou
2009-05-20 18:50 ` James Bottomley
2009-05-20 18:58 ` Jeff Garzik
2009-05-20 19:04 ` Jeff Garzik
2009-05-20 19:42 ` Gwendal Grignou
2009-05-20 19:47 ` Jeff Garzik
2009-05-21 13:44 ` Mark Lord
2009-05-21 17:27 ` Jeff Garzik
2009-05-20 18:51 ` Jeff Garzik
2009-05-20 19:09 ` Jeff Garzik
2009-06-10 15:11 ` Jeff Garzik [this message]
2009-06-11 2:10 ` Tejun Heo
2009-05-20 7:01 ` [PATCH 2/2] block: add function for waiting for a specific free tag Jens Axboe
2009-05-20 11:55 ` Tejun Heo
2009-05-20 19:34 ` old-EH and SAS (was Re: [PATCH 2/2] block: add function for waiting for a specific free tag) Jeff Garzik
2009-05-21 16:34 ` Brian King
2009-05-20 17:28 ` [PATCH 2/2] block: add function for waiting for a specific free tag Grant Grundler
2009-05-20 7:53 ` [PATCH 0/2] libata: switch to block layer tagging Jeff Garzik
2009-05-20 7:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2FCD2D.3040205@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.