From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs
Date: Wed, 10 Jun 2009 12:52:11 -0500 [thread overview]
Message-ID: <4A2FF2CB.1060805@sandeen.net> (raw)
Skip dump _cleanup if filesystem is not xfs
Many/most dump tests include common.dump before checking
supported fs, and this means that even if the dump tests
are skipped, the sleep & filesystem check in _cleanup
gets run, which makes it take rather a long time to
skip these tests for non-xfs filesystems.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/common.dump b/common.dump
index 94de07f..d5aadfc 100644
--- a/common.dump
+++ b/common.dump
@@ -233,6 +233,12 @@ _wipe_fs()
#
_cleanup()
{
+ # Some tests include this before checking _supported_fs xfs
+ # and the sleeps & checks get annoying
+ if [ "$FSTYP" != "xfs" ]; then
+ return
+ fi
+
cd $here
rm -f $tmp.*
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-06-10 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 17:52 Eric Sandeen [this message]
2009-06-10 18:54 ` [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs Christoph Hellwig
2009-06-10 20:30 ` Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2FF2CB.1060805@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.