All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Eisele <konrad@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 3/7] Introduce the sparc-leon CPU type. Add sparc_leon
Date: Thu, 11 Jun 2009 06:44:35 +0000	[thread overview]
Message-ID: <4A30A7D3.8000406@gaisler.com> (raw)
In-Reply-To: <4A2E45DC.8050802@gaisler.com>

Julian Calaby wrote:
> On Wed, Jun 10, 2009 at 20:13, <konrad@gaisler.com> wrote:
>> From: Konrad Eisele <konrad@gaisler.com>
>>
>>> We have two leon.c (+leon.o), this is confusing.
>>> Consider a better naming scheme.
>>>
>>> leon_mm.c, leon_kernel.c for example.
>> Changed to leon_m.c and leon_k.c
> 
> leon_m.c and leon_k.c are significantly better than the original
> names, however the reason that leon_mm.c and leon_kernel.c were
> suggested is that one can, at a glance, look at the file name and know
> what's going on in the file.
> 
> Not that these new names are bad, but if you re-spin these patches
> again, you might want to consider changing them.
> 
> Thanks,
> 

Ok, I can do this. I thought the smaller the better.
-- Konrad



      parent reply	other threads:[~2009-06-11  6:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09 11:22 [PATCH 3/7] Introduce the sparc-leon CPU type Konrad Eisele
2009-06-09 20:06 ` Sam Ravnborg
2009-06-10 10:13 ` [PATCH 3/7] Introduce the sparc-leon CPU type. Add sparc_leon enum, konrad
2009-06-10 23:23 ` [PATCH 3/7] Introduce the sparc-leon CPU type. Add sparc_leon Julian Calaby
2009-06-11  6:44 ` Konrad Eisele [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A30A7D3.8000406@gaisler.com \
    --to=konrad@gaisler.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.