From: Martin Fuzzey <mfuzzey@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, nico@cam.org
Subject: Re: [RFC PATCH] Ethtool style in kernel network driver configuration.
Date: Thu, 11 Jun 2009 08:47:32 +0200 [thread overview]
Message-ID: <4A30A884.9000508@gmail.com> (raw)
In-Reply-To: <1244685768.4616.22.camel@deadeye>
Ben Hutchings wrote:
> Who needs this feature? Why not use ethtool in an initramfs?
>
>
> Forcing speed and duplex is occasionally needed to work around a link
> partner that doesn't implement autonegotiation correctly. I don't see
> that it should ever be needed in platform configuration. If the driver
> doesn't detect the MAC/PHY capabilities correctly then the driver should
> be fixed. Overriding the settings once will not prevent an unsupported
> mode being selected later.
>
>
To summarize the recent points I made in the smc91x: forcing speed thread :
1) Setting up and maintaining an initramfs can increase the complexity
for embedded systems - it's another image file to build, distribute,
update to bootloader etc.
2) While I of course agree that broken drivers should be fixed, what
about broken hardware?
I currently have this situation on one of my boards - 100Mbps doesn't
work due to electrical issues (bad routing).
This board is already in the wild - if it is fixed one day it will be a
new hardware revision and the code will have to cope with both.
Sure the "right" way is to fix the hardware but that's not always
economically or logistically possible.
I suspect such situations are not uncommon in the embedded world.
Martin
next prev parent reply other threads:[~2009-06-11 6:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 17:34 [RFC PATCH] Ethtool style in kernel network driver configuration Martin Fuzzey
2009-06-10 18:02 ` Joe Perches
2009-06-11 2:02 ` Ben Hutchings
2009-06-11 3:55 ` Nicolas Pitre
2009-06-11 6:47 ` Martin Fuzzey [this message]
2009-06-11 14:54 ` Ben Hutchings
2009-06-11 16:22 ` Nicolas Pitre
2009-06-11 16:52 ` Ben Hutchings
2009-06-11 17:44 ` Nicolas Pitre
2009-06-11 18:29 ` Ben Hutchings
2009-06-11 19:08 ` Nicolas Pitre
2009-06-11 19:31 ` Ben Hutchings
2009-06-11 20:24 ` Nicolas Pitre
2009-06-11 20:48 ` Ben Hutchings
2009-06-11 21:39 ` Martin Fuzzey
2009-06-12 0:15 ` David Miller
2009-06-12 0:38 ` Nicolas Pitre
2009-06-12 2:57 ` David Miller
2009-06-11 17:45 ` Martin Fuzzey
2009-06-12 0:09 ` David Miller
2009-06-12 10:50 ` Mark Brown
2009-06-12 11:33 ` David Miller
2009-06-12 12:24 ` Mark Brown
2009-06-13 0:01 ` David Miller
2009-06-13 17:10 ` Mark Brown
2009-06-12 12:19 ` Martin Fuzzey
2009-06-13 0:01 ` David Miller
2009-06-13 7:00 ` Martin Fuzzey
2009-06-13 7:07 ` David Miller
2009-06-13 7:51 ` Martin Fuzzey
2009-06-13 8:07 ` David Miller
2009-06-13 9:29 ` Martin Fuzzey
2009-06-14 18:39 ` Martin Fuzzey
2009-06-12 0:07 ` David Miller
2009-06-12 0:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A30A884.9000508@gmail.com \
--to=mfuzzey@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.