All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Re-instate partial activation support in clustered mode.
Date: Thu, 11 Jun 2009 11:57:46 +0200	[thread overview]
Message-ID: <4A30D51A.4040808@redhat.com> (raw)
In-Reply-To: <874ouom21n.fsf@mornfall.net>

Petr Rockai wrote:
> the patch from September 2008 (partial activation revamp) broke clustered
> activation for the partial mode. This is currently more serious, since
> lvconvert --repair relies on this functionality (see BZ 504699).

I am going to test it now, just one thing: when introducing new lock flags
etc. please also fix debugging code, so in log new flags appear decoded.

I mean
@@ -145,7 +145,8 @@ static const char *decode_flags(unsigned char flags)
 {
 	static char buf[128];
 
-	sprintf(buf, "0x%x (%s%s)", flags,
+	sprintf(buf, "0x%x (%s%s%s)", flags,
+		flags & LCK_PARTIAL_MODE	  ? "PARTIAL_MODE " : "",
 		flags & LCK_MIRROR_NOSYNC_MODE	  ? "MIRROR_NOSYNC " : "",
 		flags & LCK_DMEVENTD_MONITOR_MODE ? "DMEVENTD_MONITOR " : "");


Also do_lock_lv() should clear cmd->partial_activation before releasing lvm_lock,
(all flags are handled that way, so better do not change logic here).

Milan



      reply	other threads:[~2009-06-11  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 17:28 [PATCH] Re-instate partial activation support in clustered mode Petr Rockai
2009-06-11  9:57 ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A30D51A.4040808@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.