From: Paolo Bonzini <paolo.bonzini@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Paolo Bonzini <bonzini@gnu.org>, git@vger.kernel.org
Subject: Re: [PATCH] git-format-patch, git-send-email: generate/handle escaped >From
Date: Thu, 11 Jun 2009 13:58:36 +0200 [thread overview]
Message-ID: <4A30F16C.5040207@gmail.com> (raw)
In-Reply-To: <20090611105538.GA4409@coredump.intra.peff.net>
> But of course, which conversion you want depends entirely on what you
> are going to feed it to, and which mbox they are expecting. Which is why
> it really should be configurable.
>
> Your use case looks to be feeding it to send-email
Almost, :-) because git-send-email does not support sending multiple
messages out of one mbox file. I have an upcoming patch to add this
support, and I was just "feeling the waters" before posting it.
> I suspect you would
> be better served by improving the 'From ' detection in send-email,
> probably to something like:
>
> /^From \S+ \w{3} \w{3} \d+ \d\d:\d\d:\d\d \d+/
>
> though that may be too strict. It would probably make sense to steal one
> from one of the many mbox-reading CPAN modules.
Good idea. I'll let others speak and can make this configurable (as
well as use the s/^>*From />&/ conversion), but if no one speaks, I'll
change my git-send-email patch to use the above regex or a similar one,
and withdraw this patch.
Thanks for the prompt remark!
Paolo
next prev parent reply other threads:[~2009-06-11 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 10:00 [PATCH] git-format-patch, git-send-email: generate/handle escaped >From Paolo Bonzini
2009-06-11 10:55 ` Jeff King
2009-06-11 11:58 ` Paolo Bonzini [this message]
2009-06-28 7:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A30F16C.5040207@gmail.com \
--to=paolo.bonzini@gmail.com \
--cc=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.