All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Xenomai core <Xenomai-core@domain.hid>
Subject: [Xenomai-core] [PATCH] Reorder headers include directives.
Date: Thu, 11 Jun 2009 14:40:13 +0200	[thread overview]
Message-ID: <4A30FB2D.6050003@domain.hid> (raw)

Following usual Linux rules, asm/* headers should be included after linux/*
headers, and this fixes the following warning on ARM:

In file included from arch/arm/include/asm/pgtable.h:449,
from kernel/xenomai/skins/rtdm/drvlib.c:37:
include/asm-generic/pgtable.h:305: warning: 'struct vm_area_struct' declared inside parameter list
(...)
---
 ksrc/skins/rtdm/drvlib.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ksrc/skins/rtdm/drvlib.c b/ksrc/skins/rtdm/drvlib.c
index 2d28e09..c5b2b91 100644
--- a/ksrc/skins/rtdm/drvlib.c
+++ b/ksrc/skins/rtdm/drvlib.c
@@ -31,12 +31,12 @@
  */

 #include <linux/bitops.h>
-#include <asm/page.h>
-#include <asm/io.h>
-#include <asm/pgtable.h>
 #include <linux/delay.h>
 #include <linux/mman.h>
 #include <linux/highmem.h>
+#include <asm/page.h>
+#include <asm/io.h>
+#include <asm/pgtable.h>

 #include <rtdm/rtdm_driver.h>

--
1.5.6.5


-- 
                                          Gilles



                 reply	other threads:[~2009-06-11 12:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A30FB2D.6050003@domain.hid \
    --to=gilles.chanteperdrix@xenomai.org \
    --cc=Xenomai-core@domain.hid \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.