From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 5 of 5] qemu: implement support for secondary consoles in the console backend
Date: Thu, 11 Jun 2009 17:23:54 +0200 [thread overview]
Message-ID: <4A31218A.4060908@redhat.com> (raw)
In-Reply-To: <4A311DD4.2050007@eu.citrix.com>
Hi,
> + if (!xendev->dev)
> + snprintf(con->console, sizeof(con->console), "%s/console", dom);
> + else
> + snprintf(con->console, sizeof(con->console), "%s/device/console/%d", dom, xendev->dev);
> + if (!xendev->dev)
> + con->sring = xc_map_foreign_range(xen_xc, con->xendev.dom,
> + else
> + con->sring = xc_gnttab_map_grant_ref(xendev->gnttabdev, con->xendev.dom,
> + if (!xendev->gnttabdev)
> + munmap(con->sring, XC_PAGE_SIZE);
> + else
> + xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);
This should check for xendev->dev too, like the other ones.
Also this changes code already merged to upstream qemu, so it should be
crossposted to qemu-devel.
cheers,
Gerd
next prev parent reply other threads:[~2009-06-11 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 15:08 [PATCH 5 of 5] qemu: implement support for secondary consoles in the console backend Stefano Stabellini
2009-06-11 15:23 ` Gerd Hoffmann [this message]
2009-06-11 16:02 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A31218A.4060908@redhat.com \
--to=kraxel@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.