From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 5 of 5] qemu: implement support for secondary
	consoles in the console backend
Date: Thu, 11 Jun 2009 17:02:20 +0100
Message-ID: <4A312A8C.4000606@eu.citrix.com>
References: <4A311DD4.2050007@eu.citrix.com> <4A31218A.4060908@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4A31218A.4060908@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Gerd Hoffmann wrote:

>    Hi,
> 
>> +    if (!xendev->dev)
>> +        snprintf(con->console, sizeof(con->console), "%s/console", dom);
>> +    else
>> +        snprintf(con->console, sizeof(con->console), "%s/device/console/%d", dom, xendev->dev);
> 
>> +    if (!xendev->dev)
>> +        con->sring = xc_map_foreign_range(xen_xc, con->xendev.dom,
>> +    else
>> +        con->sring = xc_gnttab_map_grant_ref(xendev->gnttabdev, con->xendev.dom,
> 
>> +        if (!xendev->gnttabdev)
>> +	    munmap(con->sring, XC_PAGE_SIZE);
>> +        else
>> +            xc_gnttab_munmap(xendev->gnttabdev, con->sring, 1);
> 
> This should check for xendev->dev too, like the other ones.

right.

> Also this changes code already merged to upstream qemu, so it should be 
> crossposted to qemu-devel.


I'll do.