From: Ian molton <spyro@f2s.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ian Molton <ian@mnementh.co.uk>,
Pierre Ossman <pierre@ossman.eu>
Subject: Re: [PATCH 7/7] mmc: tmio_mmc: allow compilation for ASIC3
Date: Fri, 12 Jun 2009 22:47:06 +0100 [thread overview]
Message-ID: <4A32CCDA.20802@f2s.com> (raw)
In-Reply-To: <1244139157-16404-8-git-send-email-philipp.zabel@gmail.com>
Does this patch actually _do_ anything? wont the asic3 driver need
modifying to use tmio_mmc before this patch is useful?
Is the idea that this patch go in and asic3 MFDs migrate gradually?
If so then I'll ack it.
Philipp Zabel wrote:
> Now tmio_mmc is able to drive the MMC/SD cell in ASIC3.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> Cc: Pierre Ossman <pierre@ossman.eu>
> Cc: Ian Molton <spyro@f2s.com>
> ---
> drivers/mmc/host/Kconfig | 4 ++--
> drivers/mmc/host/tmio_mmc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index b4cf691..9aae7f5 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -237,7 +237,7 @@ config MMC_SDRICOH_CS
>
> config MMC_TMIO
> tristate "Toshiba Mobile IO Controller (TMIO) MMC/SD function support"
> - depends on MFD_TMIO
> + depends on MFD_TMIO || MFD_ASIC3
> help
> This provides support for the SD/MMC cell found in TC6393XB,
> - T7L66XB and also ipaq ASIC3
> + T7L66XB and also HTC ASIC3.
> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> index 9f6e180..9f68c2f 100644
> --- a/drivers/mmc/host/tmio_mmc.c
> +++ b/drivers/mmc/host/tmio_mmc.c
> @@ -10,7 +10,7 @@
> *
> * Driver for the MMC / SD / SDIO cell found in:
> *
> - * TC6393XB TC6391XB TC6387XB T7L66XB
> + * TC6393XB TC6391XB TC6387XB T7L66XB ASIC3
> *
> * This driver draws mainly on scattered spec sheets, Reverse engineering
> * of the toshiba e800 SD driver and some parts of the 2.4 ASIC3 driver (4 bit
next prev parent reply other threads:[~2009-06-12 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 18:12 [PATCH 0/7] ASIC3 support for tmio_mmc Philipp Zabel
2009-06-04 18:12 ` [PATCH 1/7] MFD,mmc: tmio_mmc: make HCLK configurable Philipp Zabel
2009-06-04 22:55 ` Samuel Ortiz
2009-06-04 18:12 ` [PATCH 2/7] mmc: tmio_mmc: add bus_shift support Philipp Zabel
2009-06-04 18:12 ` [PATCH 3/7] mmc: tmio_mmc: don't use set_irq_type (v2) Philipp Zabel
2009-06-04 18:12 ` [PATCH 4/7] mmc: tmio_mmc: correct probe return value for num_resources != 3 Philipp Zabel
2009-06-04 18:12 ` [PATCH 5/7] mmc: tmio_mmc: map SD control registers after enabling the MFD cell Philipp Zabel
2009-06-12 21:36 ` Ian molton
2009-06-04 18:12 ` [PATCH 6/7] mmc: tmio_mmc: fix SDCLK divider setting Philipp Zabel
2009-06-12 21:44 ` Ian Molton
2009-06-04 18:12 ` [PATCH 7/7] mmc: tmio_mmc: allow compilation for ASIC3 Philipp Zabel
2009-06-12 21:47 ` Ian molton [this message]
2009-06-12 22:38 ` pHilipp Zabel
2009-06-13 11:58 ` [PATCH 0/7] ASIC3 support for tmio_mmc Pierre Ossman
2009-06-13 18:42 ` Ian Molton
2009-06-13 19:32 ` Pierre Ossman
2009-06-13 19:57 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A32CCDA.20802@f2s.com \
--to=spyro@f2s.com \
--cc=ian@mnementh.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.