Re: [Qemu-devel] [PATCH] Incorrect MBAR offset for an5206 UART2 output port bit set

[Anthony Liguori <aliguori@us.ibm.com>]

Evan Goldenberg wrote:
> The MBAR offset for the UART2 output port bit set function on the
> an5206 board, though unimplemented, is incorrectly defined as 0x1c8.
> The correct offset used by the hardware for this function is 0x1b8.
> This typo causes QEMU to crash whenever attempts to access use UART2
> are made:
>
> qemu: fatal: Bad MBAR write offset 0x1b8
>
> The following patch resolves this issue.
>
> diff --git a/hw/mcf5206.c b/hw/mcf5206.c
> index b570376..8bf11a4 100644
> --- a/hw/mcf5206.c
> +++ b/hw/mcf5206.c
> @@ -341,7 +341,7 @@ static void m5206_mbar_write(m5206_mbar_state *s,
> uint32_t offset,
>   

This is whitespace damaged.

>     case 0x170:
>         s->uivr[0] = value;
>         break;
> -    case 0x178: case 0x17c: case 0x1c8: case 0x1bc:
> +    case 0x178: case 0x17c: case 0x1b8: case 0x1bc:
>         /* Not implemented: UART Output port bits.  */
>         break;
>     case 0x1b0:
>
>
>
>   


-- 
Regards,

Anthony Liguori