Re: [Qemu-devel] [PATCH] mingw: Do not perform string format checks

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Filip Navara wrote:
> On Sun, Jun 14, 2009 at 8:23 PM, Jan Kiszka <jan.kiszka@web.de> wrote:
> 
>> Blue Swirl wrote:
>>> On 6/14/09, Jan Kiszka <jan.kiszka@web.de> wrote:
>>>> [ I can't check the situation with cygwin, so this is mingw-only. ]
>>>>
>>>>  gcc still does not support the Windows-specific format string modifier
>>>>  "I64". Therefore, it makes no sense to check for format string
>>>>  correctness and generate tons of false positives.
>>> I don't have this problem, currently mingw builds with zero warnings
>>> for me. But I didn't enable automatic -Werror flag for mingw just
>>> because I guessed this would happen. What's the gcc version you're
>>> using?
>> i686-pc-mingw32-gcc (GCC) 4.3.3
>>
>> Jan
>>
>> JFYI, for years there was a mingw32 patch for the format strings that
> wasn't merged into the mainline gcc. It was in the MinGW patches for at
> least 4 years. Not sure if it was merged now or not..
> Best regards,
> Filip Navara
> 

Yes, I've seen the patch while looking for the reason, but I didn't read
that it is part of mingw's gcc version. Obviously, this toolchain does
not contain it. Don't know where it was derived from (hmm, mingw is
still "testing" gcc4...). I just picked what was there (for OpenSUSE) to
include a simple win32 build run in future patch development.

Well, if everyone else out there has I64 support, then I can also add
this switch to my --extra-cflags.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]