All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaro Koskinen <aaro.koskinen@nokia.com>
To: ext Hemanth V <hemanthv@ti.com>
Cc: "dbrownell@users.sourceforge.net"
	<dbrownell@users.sourceforge.net>,
	"spi-devel-general@lists.sourceforge.net"
	<spi-devel-general@lists.sourceforge.net>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Nurkkala Eero.An (EXT-Offcode/Oulu)"
	<ext-Eero.Nurkkala@nokia.com>
Subject: Re: [PATCH] OMAP: McSPI: Fix RX DMA transfer path
Date: Mon, 15 Jun 2009 11:37:53 +0300	[thread overview]
Message-ID: <4A360861.9040403@nokia.com> (raw)
In-Reply-To: <005a01c9ed7a$2a5227b0$LocalHost@wipultra793>

Hello,

ext Hemanth V wrote:
> From: "Aaro Koskinen" <aaro.koskinen@nokia.com>
>> From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
>>
>> When data is read through DMA, the last element must be read separately
>> through the RX register. It cannot be transferred by the DMA. For further
>> details see e.g. OMAP3430 TRM.
> 
> Could you provide the section number and the version of TRM you are
> referring to.

Table 19-16 and section 19.6.2.5.1 in the public TRM.

>> Without the fix the driver causes extra clocks to be clocked to the
>> bus after DMA RX operations. This can cause interesting behaviour with
>> some devices.
> 
> Could you provide more details on the errors seen i.e is the transfer 
> aborted

There is an extra word, which a device can interpret as a command. Also 
if the word size != command size the device can hang. Unless the device 
hangs, you may not even notice anything.

A.

      reply	other threads:[~2009-06-15  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 12:31 [PATCH] OMAP: McSPI: Fix RX DMA transfer path Aaro Koskinen
     [not found] ` <1244809910-4014-1-git-send-email-aaro.koskinen-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-06-13 16:37   ` Kalle Valo
2009-06-15  7:33     ` Tony Lindgren
2009-06-18 12:26       ` Kalle Valo
2009-06-15  5:28 ` Hemanth V
2009-06-15  5:28   ` Hemanth V
2009-06-15  8:37   ` Aaro Koskinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A360861.9040403@nokia.com \
    --to=aaro.koskinen@nokia.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=ext-Eero.Nurkkala@nokia.com \
    --cc=hemanthv@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.