From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Dulloor <dulloor@gmail.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] 1 of 5: secondary consoles in minos
Date: Mon, 15 Jun 2009 10:49:29 +0100 [thread overview]
Message-ID: <4A361929.7080002@eu.citrix.com> (raw)
In-Reply-To: <940bcfd20906112155v1f86fdcif0d8d7131dde31d0@mail.gmail.com>
Dulloor wrote:
> For completeness, we should be freeing up memory(malloced for dev) in
> case of an error in xencons_ring_init. There could be other such instances.
Good point.
> Also, is it too difficult to create a consfront_dev for the first
> console and get rid of those !dev checks.
No, it is not difficult, I actually wrote it that way the first time.
However I would need to keep the checks anyway because the first console
is used even before init_console is called. Therefore I decided to avoid
calling init_console for the first console and use the !dev checks for it.
next prev parent reply other threads:[~2009-06-15 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 15:07 [PATCH] 1 of 5: secondary consoles in minos Stefano Stabellini
2009-06-12 4:55 ` Dulloor
2009-06-15 9:49 ` Stefano Stabellini [this message]
2009-06-16 10:21 ` Keir Fraser
2009-06-16 10:27 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A361929.7080002@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=dulloor@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.