From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Marcel Holtmann <marcel@holtmann.org>,
David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: rfkill regression in net-next-2.6
Date: Mon, 15 Jun 2009 15:20:59 +0200 [thread overview]
Message-ID: <4A364ABB.6040704@hartkopp.net> (raw)
In-Reply-To: <1245068686.23912.0.camel@johannes.local>
Johannes Berg wrote:
> On Mon, 2009-06-15 at 08:04 -0400, John W. Linville wrote:
>> On Sun, Jun 14, 2009 at 10:54:17AM +0200, Oliver Hartkopp wrote:
>>
>>> Any idea what changed in net-next-2.6 that could produce this behaviour?
>> The rfkill subsystem rewrite would seem suspect... :-)
>
> Maybe this fixes it?
Yes, that made it!
I booted with the RFKILL switch ON and OFF and the system and the LEDs are
working as one would expect it.
Thanks Johannes.
Tested-by: Oliver Hartkopp <oliver@hartkopp.net>
>
> johannes
>
> --- wireless-testing.orig/drivers/platform/x86/dell-laptop.c 2009-06-15 14:23:25.000000000 +0200
> +++ wireless-testing/drivers/platform/x86/dell-laptop.c 2009-06-15 14:23:35.000000000 +0200
> @@ -177,7 +177,7 @@ dell_send_request(struct calling_interfa
> static int dell_rfkill_set(void *data, bool blocked)
> {
> struct calling_interface_buffer buffer;
> - int disable = blocked ? 0 : 1;
> + int disable = blocked ? 1 : 0;
> unsigned long radio = (unsigned long)data;
>
> memset(&buffer, 0, sizeof(struct calling_interface_buffer));
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-06-15 13:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 15:20 pull request: wireless-next-2.6 2009-06-04 John W. Linville
2009-06-07 10:37 ` David Miller
2009-06-07 14:18 ` Oliver Hartkopp
2009-06-07 14:58 ` John W. Linville
2009-06-07 15:04 ` Oliver Hartkopp
2009-06-07 15:04 ` Oliver Hartkopp
2009-06-07 15:11 ` Oliver Hartkopp
2009-06-07 15:11 ` Oliver Hartkopp
2009-06-07 15:26 ` John W. Linville
2009-06-07 15:29 ` Marcel Holtmann
2009-06-07 15:29 ` Marcel Holtmann
2009-06-14 8:54 ` rfkill regression in net-next-2.6 Oliver Hartkopp
2009-06-14 8:54 ` Oliver Hartkopp
2009-06-14 9:17 ` Oliver Hartkopp
2009-06-14 9:17 ` Oliver Hartkopp
2009-06-15 12:04 ` John W. Linville
2009-06-15 12:04 ` John W. Linville
2009-06-15 12:24 ` Johannes Berg
2009-06-15 12:24 ` Johannes Berg
2009-06-15 13:20 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A364ABB.6040704@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.