From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH] exofs: Avoid using file_fsync()
Date: Mon, 15 Jun 2009 20:23:49 +0300
Message-ID: <4A3683A5.2090908@panasas.com>
References: <4A364D15.1080105@panasas.com> <20090615135044.GA2553@infradead.org> <4A3682FC.6010000@garzik.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Christoph Hellwig <hch@infradead.org>,
	open-osd mailing-list <osd-dev@open-osd.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from ip67-152-220-66.z220-152-67.customer.algx.net ([67.152.220.66]:20792
	"EHLO daytona.int.panasas.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754105AbZFORXt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 15 Jun 2009 13:23:49 -0400
In-Reply-To: <4A3682FC.6010000@garzik.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 06/15/2009 08:21 PM, Jeff Garzik wrote:
> Christoph Hellwig wrote:
>> On Mon, Jun 15, 2009 at 04:31:01PM +0300, Boaz Harrosh wrote:
>>> +	ret = write_inode_now(inode, 0);
>> You shouldn't need a write_inode_now, but rather just a similar
>> sync_inode call as in ext2 or the new simple_fsync as data was
>> already written by the VFS.
> 
> And then there is the issue of needing to flush the storage device, 
> otherwise fsync(2) does not provide relevant guarantees...
> 
> 	Jeff
> 

Right thanks, I need to do this too, will do

Boaz