Re: [PATCH]fix pci.py

[Zhigang Wang <zhigang.x.wang@oracle.com>]

Simon Horman wrote:
> On Mon, Jun 15, 2009 at 06:30:22PM +0800, Zhigang Wang wrote:
>> hi,
>>
>> this patch adds support for older pciutils without -vmm option, and improves error handling
>> in get_info_from_lspci().
>>
>> see the test case and test result for detail.
>>
>> Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>
> 
> Hi,
> 
> This looks good, but could you make a more informative subject-line?
> 
ok.

This patch adds support for older pciutils without -vmm option, and improves error handling
in get_info_from_lspci().

pciutils before commit: 3fd6b4d2e2fda814047664ffc67448ac782a8089 in
git://git.kernel.org/pub/scm/utils/pciutils/pciutils.git
has no -vmm option (it equals -vm). the result of lspci -vmm looks like:

Device: 02:00.0
Class:  Ethernet controller
Vendor: Broadcom Corporation
Device: NetXtreme BCM5751 Gigabit Ethernet PCI Express
SVendor:        Dell
SDevice:        Optiplex GX620
Rev:    01

Two Device as key.

pciutils with -vmm option:

Slot:   07:07.0
Class:  IDE interface
Vendor: Silicon Image, Inc.
Device: PCI0680 Ultra ATA-133 Host Controller
SVendor:        Silicon Image, Inc.
SDevice:        SiI 0680 ATA/133 Controller
Rev:    02
ProgIf: 85

The first Device becomes Slot.

For the second part of this patch: without this patch, only an KeyError raise,
it will not parse the extra keys, while the other keys still contains useful info.

Eg.

Slot:   07:02.0
Class:  VGA compatible controller
Vendor: ATI Technologies Inc
Device: Radeon RV100 QY [Radeon 7000/VE]
SVendor:        Dell
SDevice:        Device 0183

without a "Rev", it will not parse any of these fields.

thanks,

zhigang

> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel