All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Eykholt <jeykholt-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: "devel-s9riP+hp16TNLxjTenLetw@public.gmane.org"
	<devel-s9riP+hp16TNLxjTenLetw@public.gmane.org>,
	Linux SCSI Mailing List
	<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: duplicated host_no
Date: Mon, 15 Jun 2009 23:05:50 -0700	[thread overview]
Message-ID: <4A37363E.7090605@cisco.com> (raw)

Cool bug.  Two SCSI devs with the same host_id.

This is with fcoe and a bunch of patches in development.

I ran a loop including creating and deleting a bunch of fcoe instances on an MP system.
After 140 some times, I see this:

[ 7250.276749] scsi148 : FCoE Driver
[ 7250.276752] device eth0 entered promiscuous mode
[ 7250.276784] scsi148 : FCoE Driver
[ 7250.277526] host148: lport ffffffff: Entered RESET state from none state
[ 7250.277530] libfc: Link up on port (     0)
[ 7250.277532] host148: lport      0: Entered FLOGI state from reset state
[ 7250.305961] ------------[ cut here ]------------
[ 7250.310653] WARNING: at fs/sysfs/dir.c:487 sysfs_add_one+0xc7/0xde()
[ 7250.317096] Hardware name: X7DB8
[ 7250.320372] sysfs: cannot create duplicate filename '/bus/scsi/devices/host148'

This is unlikely to show up in real life, but it can happen in
stress tests like this, and the system doesn't work so well afterwards.

I'll submit a patch that uses atomic_inc_return for the host numbers.

	Joe

                 reply	other threads:[~2009-06-16  6:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37363E.7090605@cisco.com \
    --to=jeykholt-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
    --cc=devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.