All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Thomas Adam <thomas.adam22@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv3 2/4] git-sh-setup: introduce say() for quiet options
Date: Tue, 16 Jun 2009 10:13:12 +0200	[thread overview]
Message-ID: <4A375418.8050401@viscovery.net> (raw)
In-Reply-To: <1245117905-19351-3-git-send-email-bebarino@gmail.com>

Stephen Boyd schrieb:
> +say () {
> +	if test -z "$GIT_QUIET"
> +	then
> +		printf "%s" "$*"
> +		echo

You can squash these two lines into

		printf '%s\n' "$*"

-- Hannes

  parent reply	other threads:[~2009-06-16  8:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  2:05 [PATCHv3 0/4] Teach shell scripts to be quiet Stephen Boyd
2009-06-16  2:05 ` [PATCHv3 1/4] t4150: test applying with a newline in subject Stephen Boyd
2009-06-16  2:05   ` [PATCHv3 2/4] git-sh-setup: introduce say() for quiet options Stephen Boyd
2009-06-16  2:05     ` [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say() Stephen Boyd
2009-06-16  2:05       ` [PATCHv3 4/4] am, rebase: teach quiet option Stephen Boyd
2009-06-16  5:57         ` Junio C Hamano
2009-06-16  7:50           ` Stephen Boyd
2009-06-16  5:56       ` [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say() Junio C Hamano
2009-06-16  6:18         ` Junio C Hamano
2009-06-16  7:38         ` Stephen Boyd
2009-06-16  8:13     ` Johannes Sixt [this message]
2009-06-16 22:32 ` [PATCHv4 0/5] Teach shell scripts to be quiet Stephen Boyd
2009-06-16 22:32   ` [PATCHv4 1/5] t4150: test applying with a newline in subject Stephen Boyd
2009-06-16 22:32     ` [PATCHv4 2/5] am: suppress apply errors when using 3-way Stephen Boyd
2009-06-16 22:32       ` [PATCHv4 3/5] git-sh-setup: introduce say() for quiet options Stephen Boyd
2009-06-16 22:33         ` [PATCHv4 4/5] submodule, repack: migrate to git-sh-setup's say() Stephen Boyd
2009-06-16 22:33           ` [PATCHv4 5/5] am, rebase: teach quiet option Stephen Boyd
2009-06-18  1:07             ` [PATCHv4 6/5] stash: " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A375418.8050401@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=thomas.adam22@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.