From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
perex@perex.cz
Subject: Re: net: fix network drivers ndo_start_xmit() return values
Date: Tue, 16 Jun 2009 11:27:50 +0200 [thread overview]
Message-ID: <4A376596.7020602@trash.net> (raw)
In-Reply-To: <20090616061603.GA4494@ff.dom.local>
Jarek Poplawski wrote:
>> --- a/drivers/net/wan/lapbether.c
>> +++ b/drivers/net/wan/lapbether.c
>> @@ -149,46 +149,42 @@ static int lapbeth_data_indication(struct net_device *dev, struct sk_buff *skb)
>> */
>> static int lapbeth_xmit(struct sk_buff *skb, struct net_device *dev)
>> {
>> - int err = -ENODEV;
>> + int err;
>>
>> /*
>> * Just to be *really* sure not to send anything if the interface
>> * is down, the ethernet device may have gone.
>> */
>> if (!netif_running(dev)) {
>> + // XXX
Oops, wrong diff :) Will resend in a minute.
prev parent reply other threads:[~2009-06-16 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 17:00 net: fix network drivers ndo_start_xmit() return values Patrick McHardy
2009-06-16 6:16 ` Jarek Poplawski
2009-06-16 7:12 ` Jarek Poplawski
2009-06-16 9:22 ` David Miller
2009-06-16 9:33 ` Patrick McHardy
2009-06-17 11:33 ` David Miller
2009-06-16 9:31 ` Patrick McHardy
2009-06-16 9:46 ` Jarek Poplawski
2009-06-16 9:49 ` Patrick McHardy
2009-06-16 9:55 ` Jarek Poplawski
2009-06-16 9:27 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A376596.7020602@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.