All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dor Laor <dlaor@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Write complete sectors
Date: Tue, 16 Jun 2009 13:03:23 +0300	[thread overview]
Message-ID: <4A376DEB.4070008@redhat.com> (raw)
In-Reply-To: <1245144690-27805-1-git-send-email-kwolf@redhat.com>

On 06/16/2009 12:31 PM, Kevin Wolf wrote:
> Once upon a time, there was a bdrv_pwrite that actually wrote single bytes to
> the file... However, today it is emulated by a read-modify-write cycle which
> aligns the request to sector size. This is slow. And we don't need it: qcow2
> often has the complete sector in memory, we don't need to read it from the disk
> again.
>
> These patches change the writes to L1 tables, L2 tables and refcount blocks to
> write complete sectors instead of single entries.
>
> This series depends on the qcow2 split to apply cleanly.
>
>    

If it's not an RFC, you better prepare a git tree for Anthony to pull from
and described how did you test it. Maybe committing the qemu-io scripts
would also be a move in the right direction.
Cheers,
Dor

> Kevin Wolf (3):
>    l2_allocate: Write complete sectors
>    alloc_cluster_link_l2: Write complete sectors
>    update_refcount: Write complete sectors
>
>   block/qcow2-cluster.c  |   61 +++++++++++++++++++++++++++++++++++++++++------
>   block/qcow2-refcount.c |   34 ++++++++++++++++++++------
>   2 files changed, 79 insertions(+), 16 deletions(-)
>
>
>
>    

  parent reply	other threads:[~2009-06-16 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  9:31 [Qemu-devel] [PATCH 0/3] qcow2: Write complete sectors Kevin Wolf
2009-06-16  9:31 ` [Qemu-devel] [PATCH 1/3] l2_allocate: " Kevin Wolf
2009-06-16  9:31 ` [Qemu-devel] [PATCH 2/3] alloc_cluster_link_l2: " Kevin Wolf
2009-06-16  9:31 ` [Qemu-devel] [PATCH 3/3] update_refcount: " Kevin Wolf
2009-06-16 10:03 ` Dor Laor [this message]
2009-06-16 10:15   ` [Qemu-devel] [PATCH 0/3] qcow2: " Kevin Wolf
2009-06-16 10:06 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A376DEB.4070008@redhat.com \
    --to=dlaor@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.