From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MGZMZ-0004Br-UK for mharc-grub-devel@gnu.org; Tue, 16 Jun 2009 10:10:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGZMV-0004Bh-UA for grub-devel@gnu.org; Tue, 16 Jun 2009 10:10:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGZMR-0004BV-HO for grub-devel@gnu.org; Tue, 16 Jun 2009 10:10:07 -0400 Received: from [199.232.76.173] (port=54817 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGZMR-0004BS-C0 for grub-devel@gnu.org; Tue, 16 Jun 2009 10:10:03 -0400 Received: from nougat.ucs.ed.ac.uk ([129.215.13.205]:56368) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGZMQ-0004Tg-Mx for grub-devel@gnu.org; Tue, 16 Jun 2009 10:10:03 -0400 Received: from lmtp1.ucs.ed.ac.uk (lmtp1.ucs.ed.ac.uk [129.215.149.64]) by nougat.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id n5GE9WpB002898 for ; Tue, 16 Jun 2009 15:09:32 +0100 (BST) Received: from emperor.ucs.ed.ac.uk (emperor.ucs.ed.ac.uk [194.81.249.143]) by lmtp1.ucs.ed.ac.uk (8.13.8/8.13.7) with ESMTP id n5GE9WNG028487 for ; Tue, 16 Jun 2009 15:09:32 +0100 (BST) Message-ID: <4A37A79C.4020106@ed.ac.uk> Date: Tue, 16 Jun 2009 15:09:32 +0100 From: James Jarvis User-Agent: Thunderbird 2.0.0.19 (X11/20090107) MIME-Version: 1.0 To: The development of GRUB 2 References: <4A2CF763.50105@ed.ac.uk> <4A2D14A7.4040405@ed.ac.uk> <48f46e890906082047j51afd316gf2bd1566c45875f8@mail.gmail.com> <4A2E751F.5090905@ed.ac.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Edinburgh-Scanned: at nougat.ucs.ed.ac.uk with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus X-Scanned-By: MIMEDefang 2.60 on 129.215.13.205 X-Scanned-By: MIMEDefang 2.52 on 129.215.149.64 Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: echo and hello bug X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2009 14:10:08 -0000 Vladimir 'phcoder' Serbinenko wrote: >> tried this module list in grub-mkimage on 2282 but it hung! >> > I think you have a problem with you building system. If you want ping > me (phcoder) on IRC and I'll compile for you > Shamed me into looking deeper! I discover that by listing hello and echo first in the grub-mkimage command they both work as expected. Not sure why this occurs - is there a file detailing module dependencies one can look at? Anyway, whilst looking through the code I did spot a semantic error, fix shown in this patch: Index: echo.c =================================================================== --- echo.c (revision 2331) +++ echo.c (working copy) @@ -113,7 +113,7 @@ GRUB_MOD_INIT(echo) { cmd = grub_register_extcmd ("echo", grub_cmd_echo, GRUB_COMMAND_FLAG_BOTH, - "echo [-e|-n] FILE", "Display a line of text.", + "echo [-e|-n] STRING", "Display a line of text.", options); } James -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.