From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH] update stubdom config example Date: Tue, 16 Jun 2009 17:09:24 +0100 Message-ID: <4A37C3B4.90601@eu.citrix.com> References: <4A37BE49.4070400@eu.citrix.com> <20090616155652.GT5866@const.bordeaux.inria.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20090616155652.GT5866@const.bordeaux.inria.fr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault , Stefano Stabellini , xen-devel List-Id: xen-devel@lists.xenproject.org Samuel Thibault wrote: > Stefano Stabellini, le Tue 16 Jun 2009 16:46:17 +0100, a =C3=A9crit : >> this patch updates the stubdom config example to reflect that the seri= al >> option can now be used. >=20 > Ok, so now I see what your previous patch is for :) I still think > openpty() shouldn't be used, as a standard function with the same name > but different prototype exists, that would lead us to troubles. I would > rather see it as open("/dev/ptmx") and/or posix_openpt(), which actuall= y > does the same, but can be interfaced in a standard way. And then we > could even implement pts_name() to provide the console frontend path. >=20 I wasn't aware of posix_openpt, I think that is the best choice. I'll resend the patch and also update the qemu patch that uses it.