All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Corentin Chary <corentincj@iksaif.net>,
	Len Brown <len.brown@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: [PATCH -next] eeepc: fix selects (third time)
Date: Tue, 16 Jun 2009 10:44:58 -0700	[thread overview]
Message-ID: <4A37DA1A.8020800@oracle.com> (raw)
In-Reply-To: <20090616165923.8ca4ddcb.sfr@canb.auug.org.au>

linux-next still fails with various pci_*() undefined references, like:


ERROR: "pci_scan_slot" [drivers/pci/hotplug/cpqphp.ko] undefined!
ERROR: "pci_add_new_bus" [drivers/pci/hotplug/cpqphp.ko] undefined!
and
drivers/pci/hotplug/fakephp.c:55: error:implicit declaration of function 'pci_rescan_bus'

These are due to the eeepc driver's Kconfig selects.  Patch below
fixes them.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

EEEPC_LAPTOP selects HOTPLUG_PCI.  This causes failures (build error below)
when CONFIG_HOTPLUG is not enabled, so additionally select HOTPLUG since
kconfig 'select' doesn't follow its dependency chain.
Also, only select HOTPLUG_PCI if PCI is already enabled.

drivers/pci/hotplug/fakephp.c:55: error: implicit declaration of function 'pci_rescan_bus'
ERROR: "pci_scan_slot" [drivers/pci/hotplug/pciehp.ko] undefined!
ERROR: "pci_scan_bridge" [drivers/pci/hotplug/pciehp.ko] undefined!
ERROR: "pci_scan_slot" [drivers/pci/hotplug/pci_hotplug.ko] undefined!
ERROR: "pci_add_new_bus" [drivers/pci/hotplug/pci_hotplug.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/platform/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20090604.orig/drivers/platform/x86/Kconfig
+++ linux-next-20090604/drivers/platform/x86/Kconfig
@@ -340,7 +340,8 @@ config EEEPC_LAPTOP
 	depends on RFKILL || RFKILL = n
 	select BACKLIGHT_CLASS_DEVICE
 	select HWMON
-	select HOTPLUG_PCI
+	select HOTPLUG
+	select HOTPLUG_PCI if PCI
 	---help---
 	  This driver supports the Fn-Fx keys on Eee PC laptops.
 	  It also adds the ability to switch camera/wlan on/off.

      parent reply	other threads:[~2009-06-16 17:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  6:59 linux-next: Tree for June 16 Stephen Rothwell
2009-06-16 16:46 ` linux-next: Tree for June 16 (osd) Randy Dunlap
2009-06-17 12:45   ` Boaz Harrosh
2009-06-17 13:12     ` Stephen Rothwell
2009-06-17 13:36       ` [PATCH][SQUASHME] osdblk is dependent on SCSI_OSD_ULD Boaz Harrosh
2009-06-17 13:49         ` Stephen Rothwell
2009-06-17 16:20         ` Randy Dunlap
2009-06-16 17:25 ` [PATCH -next] bnx2i/cnic: more kconfig dependencies Randy Dunlap
2009-06-16 17:57   ` Michael Chan
2009-06-16 17:44 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37DA1A.8020800@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=corentincj@iksaif.net \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.