All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] 83xx 85xx: UEC: Implicit declaration of function 'uec_standard_init'
Date: Tue, 16 Jun 2009 13:20:42 -0700	[thread overview]
Message-ID: <4A37FE9A.7090704@gmail.com> (raw)
In-Reply-To: <4A37FB40.20907@RuggedCom.com>

Hi Richard,

Richard Retanubun wrote:
> Hi,
>
> Since rebasing to 2009.06 release, I have been getting this compiler warning
>
> cpu.c: In function 'cpu_eth_init':
> cpu.c:372: warning: implicit declaration of function 'uec_standard_init'
>
> It is declared in /drivers/qe/uec.h, crude hacks at including the header causes even more errors:
>
> In file included from cpu.c:35:
> ../../drivers/qe/uec.h:699: error: expected specifier-qualifier-list before 'ucc_fast_info_t'
> ../../drivers/qe/uec.h:722: error: expected specifier-qualifier-list before 'ucc_fast_private_t'
> In file included from cpu.c:37:
> /home/richardretanubun/workspace/u-boot/include/netdev.h:75: error: conflicting types for 'uec_initialize'
> ../../drivers/qe/uec.h:764: error: previous declaration of 'uec_initialize' was here
> make[1]: *** [cpu.o] Error 1
> make: *** [cpu/mpc83xx/libmpc83xx.a] Error 2
>
> The side effect I see so far is that the network interface can be used once (say for tftp) but fails after that.
>
> is there a patch missing for cpu.c?
>
> - Richard
>   
Looks like some networking code snuck in through the back door:

http://git.denx.de/?p=u-boot.git;a=commit;h=8e55258f144764de8902e9f078a7ad4c6c022c2f

include/netdev.h should contain the definitive public API for device 
initialization.

Does removing '#include "netdev.h' in cpu.c fix it?

regards,
Ben

  reply	other threads:[~2009-06-16 20:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 20:06 [U-Boot] 83xx 85xx: UEC: Implicit declaration of function 'uec_standard_init' Richard Retanubun
2009-06-16 20:20 ` Ben Warren [this message]
2009-06-16 20:29   ` Richard Retanubun
2009-06-16 20:33     ` Ben Warren
2009-06-16 20:50       ` Richard Retanubun
2009-06-16 21:16         ` Kumar Gala
2009-06-17 12:27           ` Richard Retanubun
2009-06-17 13:15             ` Kumar Gala
2009-06-17 13:22         ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37FE9A.7090704@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.