All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] avoid compilation warning/errors on up to date compilers
Date: Tue, 16 Jun 2009 15:56:43 -0500	[thread overview]
Message-ID: <4A38070B.1020809@codemonkey.ws> (raw)
In-Reply-To: <20090616182359.GA17188@miranda.arrow>

Stuart Brady wrote:
> On Tue, Jun 16, 2009 at 06:03:43PM +0300, Riku Voipio wrote:
>   
>> Which tree against did you make these changes? the qemu-ndb.c bit didn't
>> apply against HEAD. Also, there are some whitespace/tab issues. See the
>> CODING_STYLE doc. Functionally I can verify it removes compiler warnings
>> when using a modenr glibc (2.9).
>>     
>
> Unfortunately, some of the changes don't look right.
>   

I think adding -D_FORTIFY_SOURCE=1 to CFLAGS is probably a better fix 
than adding broken error handling everywhere.

Regards,

Anthony Liguori

  parent reply	other threads:[~2009-06-16 20:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16  3:30 [Qemu-devel] [PATCH] avoid compilation warning/errors on up to date compilers Jean-Christophe Dubois
2009-06-16 15:03 ` Riku Voipio
2009-06-16 18:23   ` Stuart Brady
2009-06-16 20:01     ` Jean-Christophe Dubois
2009-06-16 20:56     ` Anthony Liguori [this message]
2009-06-16 21:07       ` Jean-Christophe Dubois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A38070B.1020809@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=sdbrady@ntlworld.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.