All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] qdev: Fix regression in "pci_add ... storage if=virtio, ..."
Date: Tue, 16 Jun 2009 22:58:37 +0200	[thread overview]
Message-ID: <4A38077D.8090704@redhat.com> (raw)
In-Reply-To: <87my88uuhf.fsf@pike.pond.sub.org>

   Hi,

>       case IF_VIRTIO:
>           opaque = pci_create_simple(pci_bus, -1, "virtio-blk-pci");
> -        qdev_init(opaque);
>           break;

Yep, pci_create_simple() calls qdev_init() already.
Patch looks good.

cheers,
   Gerd

      reply	other threads:[~2009-06-16 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 17:43 [Qemu-devel] Monitor command pci_add regressed (qdev) Markus Armbruster
2009-06-12  8:52 ` Gerd Hoffmann
2009-06-16 14:24 ` [Qemu-devel] [PATCH] qdev: Fix regression in "pci_add ... storage if=virtio, ..." Markus Armbruster
2009-06-16 20:58   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A38077D.8090704@redhat.com \
    --to=kraxel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.