From: Eric Miao <eric.y.miao@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Paul Shen <boshen9@gmail.com>,
alsa-devel <alsa-devel@alsa-project.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
Daniel Ribeiro <drwyrm@gmail.com>
Subject: Re: [PATCH 3/3] ASoC: pxa-ssp.c handle the I2S and LEFT_J cases.
Date: Wed, 17 Jun 2009 11:03:28 +0800 [thread overview]
Message-ID: <4A385D00.4060601@gmail.com> (raw)
In-Reply-To: <20090616213635.GA26502@sirena.org.uk>
Mark Brown wrote:
> On Mon, Jun 15, 2009 at 09:45:35PM -0300, Daniel Ribeiro wrote:
>
>> arch/arm/mach-pxa/include/mach/regs-ssp.h | 14 ++--
>
> Eric, are you happy for this change to go via ALSA? It seems reasonable
> enough.
>
> I'm happy with these changes from a code review point of view, though
> as well as Eric's ack I'll do some more testing before I apply them.
> Thanks a lot for doing this work.
OK, I'll take some time to verify that on PXA3xx.
next prev parent reply other threads:[~2009-06-17 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 0:45 [PATCH 3/3] ASoC: pxa-ssp.c handle the I2S and LEFT_J cases Daniel Ribeiro
2009-06-16 21:36 ` Mark Brown
2009-06-17 3:03 ` Eric Miao [this message]
2009-06-17 9:35 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2009-08-06 14:55 [PATCH 1/3] ASoC: change set_tdm_slot api to allow slot_width override Mark Brown
2009-08-06 14:55 ` [PATCH 3/3] ASoC: pxa-ssp.c handle the I2S and LEFT_J cases Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A385D00.4060601@gmail.com \
--to=eric.y.miao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=boshen9@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=drwyrm@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.