From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MGuSM-0006B1-Rm for qemu-devel@nongnu.org; Wed, 17 Jun 2009 08:41:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MGuSL-00069C-Tt for qemu-devel@nongnu.org; Wed, 17 Jun 2009 08:41:34 -0400 Received: from [199.232.76.173] (port=33589 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MGuSL-00068s-Oq for qemu-devel@nongnu.org; Wed, 17 Jun 2009 08:41:33 -0400 Received: from dd21438.kasserver.com ([85.13.141.110]:41085) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MGuSL-0003rJ-89 for qemu-devel@nongnu.org; Wed, 17 Jun 2009 08:41:33 -0400 Message-ID: <4A38E47B.3020806@opensuse.org> Date: Wed, 17 Jun 2009 14:41:31 +0200 From: Martin Mohring MIME-Version: 1.0 References: <200906161934.n5GJYBvD030723@d01av04.pok.ibm.com> <20090617071833.GA5636@kos.to> <761ea48b0906170032g318457e4p81d028375971f2b2@mail.gmail.com> In-Reply-To: <761ea48b0906170032g318457e4p81d028375971f2b2@mail.gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 74d753a] linux-user: strace now handles guest stringscorrectly [v2] List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: Anthony Liguori , Riku Voipio , Mika Westerberg , qemu-devel@nongnu.org Laurent Desnogues wrote: > On Wed, Jun 17, 2009 at 9:18 AM, Riku Voipio wrote: > =20 >> On Wed, Jun 17, 2009 at 02:27:06AM +0400, malc wrote: >> =20 >>> On Tue, 16 Jun 2009, Anthony Liguori wrote: >>> On my system the above line causes gcc to emit: >>> =20 >>> In file included from /home/malc/x/rcs/git/qemu/linux-user/strace.c:1= 2: >>> /usr/include/linux/futex.h:48: error: field `__user' has incomplete t= ype >>> /usr/include/linux/futex.h:48: error: syntax error before '*' token >>> /usr/include/linux/futex.h:63: error: field `list' has incomplete typ= e >>> /usr/include/linux/futex.h:83: error: field `__user' has incomplete t= ype >>> /usr/include/linux/futex.h:83: error: syntax error before '*' token >>> make[1]: *** [strace.o] Error 1 >>> =20 >>> Following fixes it, but i wonder if there's better way: >>> =20 >> It doesn't look like your kernel headers have been sanitized beforing = installing. >> futex.h exposed to userspace shouldn't have __user anywhere. >> >> Previously distros did that by hand, nowadays you can do a "make heade= rs_install" >> in the kernel tree itself. >> =20 > > I got something different on my CentOS 5.3 x86_64: > > /usr/include/linux/futex.h:108: error: expected =91)=92 before =91*=92 = token > /usr/include/linux/futex.h:112: error: expected =91)=92 before =91*=92 = token > > Apparently it lacks u32 definition. > > > Laurent > =20 I did some bigger compile test after the big user mode patch pull from yesterday for all the patches Riku and me had collected in the past weeks. I applied already the "__user patch". Also I had to disable "-Werror" option, because there are still too much warnings inside now causing an error. Results: CentOS 5 / RHEL 5 (i586/x86_64): - CentOS 5 was already reported > In file included from > /usr/src/redhat/BUILD/qemu-0.11git2009.06.16.1935/linux-user/strace.c:1= 2: > /usr/include/linux/futex.h:96: error: expected ')' before '*' token > /usr/include/linux/futex.h:100: error: expected ')' before '*' token Debian Etch/Lenny (i586/x86_64): builds Fedora 9/10 (i586/x86_64): builds SLES 11/openSUSE 11.0/openSUSE 11.1 (i586/x86_64): builds Ubuntu 8.10/9.04 (i586/x86_64): builds Regards, Martin