From: David Daney <ddaney@caviumnetworks.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] -git compile fixes for MIPS
Date: Wed, 17 Jun 2009 08:39:51 -0700 [thread overview]
Message-ID: <4A390E47.1010801@caviumnetworks.com> (raw)
In-Reply-To: <4A38A173.9010508@gmail.com>
Manuel Lauss wrote:
>
> Quick fixes for some compile failures which have cropped up
> in linus-git in the last 24 hours:
>
> CC arch/mips/kernel/time.o
> In file included from linux-2.6.git/include/linux/bug.h:4,
> from linux-2.6.git/arch/mips/kernel/time.c:13:
> linux-2.6.git/arch/mips/include/asm/bug.h:10: error: expected '=', ',',
> ';', 'asm' or '__attribute__' before 'BUG'
> linux-2.6.git/arch/mips/include/asm/bug.h: In function '__BUG_ON':
> linux-2.6.git/arch/mips/include/asm/bug.h:26: error: implicit
> declaration of function 'BUG'
>
> CC arch/mips/mm/uasm.o
> In file included from linux-2.6.git/arch/mips/mm/uasm.c:21:
> linux-2.6.git/arch/mips/include/asm/bugs.h: In function 'check_bugs':
> linux-2.6.git/arch/mips/include/asm/bugs.h:34: error: implicit
> declaration of function 'smp_processor_id'
> linux-2.6.git/arch/mips/mm/uasm.c: In function 'uasm_copy_handler':
> linux-2.6.git/arch/mips/mm/uasm.c:514: error: implicit declaration of
> function 'memcpy'
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> arch/mips/include/asm/bug.h | 2 +-
> arch/mips/include/asm/bugs.h | 1 +
> arch/mips/mm/uasm.c | 1 +
> 3 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/bug.h b/arch/mips/include/asm/bug.h
> index 08ea468..92b372a 100644
> --- a/arch/mips/include/asm/bug.h
> +++ b/arch/mips/include/asm/bug.h
> @@ -7,7 +7,7 @@
>
> #include <asm/break.h>
>
> -static inline void __noreturn BUG(void)
> +static inline void __attribute__((noreturn)) BUG(void)
That isn't correct.
__noreturn is defined in linux/compiler.h You should figure out why
that definition is not being used.
David Daney
next prev parent reply other threads:[~2009-06-17 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 7:55 [PATCH] -git compile fixes for MIPS Manuel Lauss
2009-06-17 13:35 ` Florian Fainelli
2009-06-17 15:39 ` David Daney [this message]
2009-06-17 19:27 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A390E47.1010801@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.