From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alex Chiang <achiang@hp.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: linux-next: Tree for June 17 (pci/slot)
Date: Wed, 17 Jun 2009 10:43:36 -0700 [thread overview]
Message-ID: <4A392B48.7060206@oracle.com> (raw)
In-Reply-To: <20090617102901.6e39aac2@jbarnes-g45>
Jesse Barnes wrote:
> On Wed, 17 Jun 2009 10:36:04 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> On Wed, Jun 17, 2009 at 09:26:51AM -0700, Randy Dunlap wrote:
>>> Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20090616:
>>>
>>> When CONFIG_SYSFS=n:
>>>
>>> drivers/pci/slot.c:327: error: 'module_kset' undeclared (first use
>>> in this function)
>> Is there any point to pci_slot existing without CONFIG_SYSFS?
>> I don't see how you can interact with it in any meaningful way.
>> Perhaps CONFIG_PCI_SLOT should depend on CONFIG_SYSFS?
>
> I've got a code fix queued up, but maybe a Kconfig dependency is the
> way to go...
What is the code fix like?
The Kconfig fix makes sense to me.
--
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
next prev parent reply other threads:[~2009-06-17 17:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 5:53 linux-next: Tree for June 17 Stephen Rothwell
2009-06-17 16:26 ` linux-next: Tree for June 17 (pci/slot) Randy Dunlap
2009-06-17 16:36 ` Matthew Wilcox
2009-06-17 17:29 ` Jesse Barnes
2009-06-17 17:43 ` Randy Dunlap [this message]
2009-06-17 23:10 ` Jesse Barnes
2009-06-18 0:38 ` Alex Chiang
2009-06-18 0:46 ` Alex Chiang
2009-06-18 0:58 ` Randy Dunlap
2009-06-18 1:03 ` Alex Chiang
2009-06-18 15:14 ` Randy Dunlap
2009-06-18 21:04 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A392B48.7060206@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=achiang@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.