From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MH3yy-0005Rd-2j
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 18:51:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MH3yt-0005R2-4F
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 18:51:51 -0400
Received: from [199.232.76.173] (port=59327 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MH3ys-0005Qz-Ul
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 18:51:46 -0400
Received: from qw-out-1920.google.com ([74.125.92.145]:29436)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MH3ys-0003hW-HQ
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 18:51:46 -0400
Received: by qw-out-1920.google.com with SMTP id 4so337235qwk.4
	for <qemu-devel@nongnu.org>; Wed, 17 Jun 2009 15:51:45 -0700 (PDT)
Message-ID: <4A39737F.7070101@codemonkey.ws>
Date: Wed, 17 Jun 2009 17:51:43 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up
	to date
References: <200906172322.35496.jcd@tribudubois.net>
	<4A396630.20105@codemonkey.ws>
	<200906180041.31816.jcd@tribudubois.net>
In-Reply-To: <200906180041.31816.jcd@tribudubois.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jean-Christophe Dubois <jcd@tribudubois.net>
Cc: qemu-devel@nongnu.org

Jean-Christophe Dubois wrote:
> Once again, when all warnings are suppressed I doubt anybody will volunteer 
> for this boring task. And all future code added to the project without system 
> call error check will get unnoticed because you silenced GCC.
>
> But at the end it is your call.
>   

Silencing the warnings != fixing the warnings.

To fix the warning, the errors have to be dealt with in a graceful way.  
This means either propagating the errors and releases any acquired 
resources or aborting.

It is not an improvement to just add dummy error handling in a few 
spots.  It does not result in making the code any more robust.

Regards,

Anthony Liguori

>> Regards,
>>
>> Anthony Liguori
>>     
>
>