Re: [Qemu-devel] [PATCH 3/4] Multiboot support v2

[Avi Kivity <avi@redhat.com>]

On 06/18/2009 01:22 PM, Alexander Graf wrote:
> Looking through pc.c I found for mostly without space, but if with 
> immediate space after it.
>

pc.c:

    [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'if (' hw/pc.c
    99
    [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'if(' hw/pc.c
    0
    [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'for (' hw/pc.c
    13
    [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'for(' hw/pc.c
    8


the entire tree:

    [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat |
    grep -c -F 'if ('
    25831
    [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat |
    grep -c -F 'if('
    711
    [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat |
    grep -c -F 'for ('
    2085
    [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat |
    grep -c -F 'for('
    906


The spaces win.

> Wouldn't it be more useful to write some automatic formatting script 
> git would run on patches that go in? Maybe people using tabs in the 
> wrong areas of the code would be able to submit patches by then too ;-).
>
> IMHO there is no real "qemu coding style" atm anyway - each maintainer 
> has his own and uses that for its subtree. It'd be a lot more helpful 
> to start addressing things at the root of the problems.
>

There's CODING_STYLE (which doesn't address this bit, but is a start).


-- 
error compiling committee.c: too many arguments to function