From: Jiri Slaby <jirislaby@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru
Subject: Re: inet_csk_get_port lock imbalance?
Date: Thu, 18 Jun 2009 16:23:37 +0200 [thread overview]
Message-ID: <4A3A4DE9.1050607@gmail.com> (raw)
In-Reply-To: <20090618141425.GA31266@Chamillionaire.breakpoint.cc>
On 06/18/2009 04:14 PM, Florian Westphal wrote:
> Jiri Slaby <jirislaby@gmail.com> wrote:
>> we've found a weird locking discipline in inet_csk_get_port. Who is
>> supposed to unlock the spin lock in the place marked in the code below?
> I'd appreciate it if you consider the above a blatant lie and check it again :-)
Yes, you are right, I went through 'if (remaining <= 0) {' branch
through which it can't go. Thanks.
prev parent reply other threads:[~2009-06-18 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 13:55 inet_csk_get_port lock imbalance? Jiri Slaby
2009-06-18 14:14 ` Florian Westphal
2009-06-18 14:23 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A4DE9.1050607@gmail.com \
--to=jirislaby@gmail.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.