From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russ Blaine Subject: Re: RE: GPLPV: Respecting SG capability Date: Thu, 18 Jun 2009 15:31:54 -0700 Message-ID: <4A3AC05A.3020209@sun.com> References: <49F5FA5A.7060204@sun.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000906070308040905020009" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: James Harper Cc: Mark Johnson , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------000906070308040905020009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit James Harper wrote: > We may be able to simply tell Windows that we don't support SG and it > may coalesce the buffers itself. I will do some testing of that before I > consider other workarounds. As I understand it, this isn't possible to do - Windows insists on handing us several buffers per packet. Attached is a patch against the current source - it would be helpful to have this in the upstream source so that these drivers work out of the box on Solaris dom0 (albeit with scatter/gather disabled in the frontend). A future improvement on this work will be to avoid constructing header_buf in this case, but this gets things working well enough. Another piece of future work will be to have the net driver disable sg if the backend doesn't have "feature-sg" set to 1 in xenstore. I can do a push if so desired, just let me know. Thanks, - Russ -- ----------------------------------------------------- Russ Blaine | Solaris Kernel | russell.blaine@sun.com --------------000906070308040905020009 Content-Type: text/plain; name="xennet-nosg.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="xennet-nosg.diff" ZGlmZiAtciBkNDBjNzYwYTRmNmIgeGVubmV0L3hlbm5ldC5oCi0tLSBhL3hlbm5ldC94ZW5u ZXQuaAlUdWUgSnVuIDA5IDEzOjQyOjAzIDIwMDkgKzEwMDAKKysrIGIveGVubmV0L3hlbm5l dC5oCVRodSBKdW4gMTggMTU6MjY6MjcgMjAwOSAtMDcwMApAQCAtMjc5LDYgKzI3OSw3IEBA CiAgIFVMT05HIHR4X2hiX2ZyZWU7DQogICBVTE9ORyB0eF9oYl9saXN0W1RYX0hFQURFUl9C VUZGRVJTXTsNCiAgIHNoYXJlZF9idWZmZXJfdCB0eF9oYnNbVFhfSEVBREVSX0JVRkZFUlNd Ow0KKyAgc2hhcmVkX2J1ZmZlcl90IHR4X3NlbmRidWY7DQogICBLRFBDIHR4X2RwYzsNCiAN CiAgIC8qIHJ4X3JlbGF0ZWQgLSBwcm90ZWN0ZWQgYnkgcnhfbG9jayAqLw0KZGlmZiAtciBk NDBjNzYwYTRmNmIgeGVubmV0L3hlbm5ldF90eC5jCi0tLSBhL3hlbm5ldC94ZW5uZXRfdHgu YwlUdWUgSnVuIDA5IDEzOjQyOjAzIDIwMDkgKzEwMDAKKysrIGIveGVubmV0L3hlbm5ldF90 eC5jCVRodSBKdW4gMTggMTU6MjY6MjcgMjAwOSAtMDcwMApAQCAtMjMxLDcgKzIzMSwzMCBA QAogICBjaHVua3MrKzsNCiAgIHhpLT50eF9yaW5nX2ZyZWUtLTsNCiAgIHR4MC0+aWQgPSAw eEZGRkY7DQotICBpZiAoaGVhZGVyX2J1ZikNCisgIGlmICh4aS0+Y29uZmlnX3NnID09IDAp IHsNCisgICAgICBVTE9ORyBsZW47DQorICAgICAgVUxPTkcgb2Zmc2V0ID0gMDsNCisgICAg ICBQTkRJU19CVUZGRVIgYnVmOw0KKw0KKyAgICAgIGJ1ZiA9IHBpLmZpcnN0X2J1ZmZlcjsN CisgICAgICB3aGlsZSAoYnVmKSB7DQorICAgICAgICAgIFBVQ0hBUiBzcmNfYWRkcjsNCisN CisgICAgICAgICAgTmRpc1F1ZXJ5QnVmZmVyU2FmZShidWYsICZzcmNfYWRkciwgJmxlbiwg Tm9ybWFsUGFnZVByaW9yaXR5KTsNCisNCisgICAgICAgICAgbWVtY3B5KChQVUNIQVIpeGkt PnR4X3NlbmRidWYudmlydHVhbCArIG9mZnNldCwgc3JjX2FkZHIsIGxlbik7DQorICAgICAg ICAgIG9mZnNldCArPSBsZW47DQorDQorICAgICAgICAgIE5kaXNHZXROZXh0QnVmZmVyKGJ1 ZiwgJmJ1Zik7DQorICAgICAgfQ0KKw0KKyAgICAgIHR4MC0+Z3JlZiA9IChncmFudF9yZWZf dCl4aS0+dHhfc2VuZGJ1Zi5sb2dpY2FsLlF1YWRQYXJ0ID4+IFBBR0VfU0hJRlQ7DQorICAg ICAgdHgwLT5vZmZzZXQgPSAoVVNIT1JUKXhpLT50eF9zZW5kYnVmLmxvZ2ljYWwuTG93UGFy dCAmIChQQUdFX1NJWkUgLSAxKTsNCisgICAgICBBU1NFUlQob2Zmc2V0ID09IHBpLnRvdGFs X2xlbmd0aCk7DQorICAgICAgdHgwLT5zaXplID0gKHVpbnQxNl90KW9mZnNldDsNCisgICAg ICB0eDAtPmZsYWdzICY9IH5ORVRUWEZfbW9yZV9kYXRhOw0KKyAgICAgIHNnX2VsZW1lbnQg PSBzZy0+TnVtYmVyT2ZFbGVtZW50czsgDQorICB9IGVsc2UgaWYgKGhlYWRlcl9idWYpDQog ICB7DQogICAgIFVMT05HIHJlbWFpbmluZyA9IHBpLmhlYWRlcl9sZW5ndGg7DQogICAgIEFT U0VSVChwaS5oZWFkZXJfbGVuZ3RoIDwgVFhfSEVBREVSX0JVRkZFUl9TSVpFKTsNCkBAIC01 ODcsNiArNjEwLDkgQEAKICAgaWYgKGkgPT0gMCkNCiAgICAgS2RQcmludCgoX19EUklWRVJf TkFNRSAiICAgICBVbmFibGUgdG8gYWxsb2NhdGUgYW55IFNoYXJlZE1lbW9yeSBidWZmZXJz XG4iKSk7DQogDQorICB4aS0+dHhfc2VuZGJ1Zi52aXJ0dWFsID0geGktPnR4X2hic1swXS52 aXJ0dWFsOw0KKyAgeGktPnR4X3NlbmRidWYubG9naWNhbCA9IHhpLT50eF9oYnNbMF0ubG9n aWNhbDsNCisNCiAgIHhpLT50eF9pZF9mcmVlID0gMDsNCiAgIGZvciAoaSA9IDA7IGkgPCBO RVRfVFhfUklOR19TSVpFOyBpKyspDQogICB7DQo= --------------000906070308040905020009 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------000906070308040905020009--