From: Li Zefan <lizf@cn.fujitsu.com>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tracing/filters: remove error messages
Date: Fri, 19 Jun 2009 13:03:52 +0800 [thread overview]
Message-ID: <4A3B1C38.5080607@cn.fujitsu.com> (raw)
In-Reply-To: <1245305452.6207.91.camel@tropicana>
Tom Zanussi wrote:
> On Thu, 2009-06-18 at 09:17 +0800, Li Zefan wrote:
>> Frederic Weisbecker wrote:
>>> On Wed, Jun 17, 2009 at 04:47:15PM +0800, Li Zefan wrote:
>>>> Now we restore original filter is the new one can't be applied,
>>>> and no long show error messages, so we can remove them totally.
>>> Why?
>>> These messages are very powerful to point a user to its mistakes
>>> in filters syntaxes or semantics.
>>>
>>> I really think we are removing a very useful feature in this patch.
>>>
>> I think it's better done by providing a user-space program/script.
>>
>> So what's the criterion to decide what should be in kernel and
>> what should be in user-space?
>>
>
> I thought there wasn't supposed to be any userspace for non-binary
> tracing.
This is a good point, and I agree on this direction.
> If there is, then yeah, you can get rid of the error messages
> in the kernel because your userspace program can arrange to never submit
> an erroneous filter.
>
next prev parent reply other threads:[~2009-06-19 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 8:46 [PATCH 1/2] tracing/filters: restore orignal filter when new filter isn't applicable Li Zefan
2009-06-17 8:47 ` [PATCH 2/2] tracing/filters: remove error messages Li Zefan
2009-06-17 12:02 ` Frederic Weisbecker
2009-06-18 1:17 ` Li Zefan
2009-06-18 6:10 ` Tom Zanussi
2009-06-19 5:03 ` Li Zefan [this message]
2009-06-18 5:58 ` [PATCH 1/2] tracing/filters: restore orignal filter when new filter isn't applicable Tom Zanussi
2009-06-18 23:18 ` Steven Rostedt
2009-06-19 4:46 ` Tom Zanussi
2009-06-19 5:02 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3B1C38.5080607@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.